From: Viresh Kumar Date: Fri, 14 Nov 2014 11:55:02 +0000 (+0530) Subject: greybus: connection: try cancelling operations only if list isn't empty X-Git-Tag: v4.9-rc1~119^2~378^2~21^2~1898 X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=38d61ddf95734c3fe69c31b867cc26932db63235;p=linux.git greybus: connection: try cancelling operations only if list isn't empty Signed-off-by: Viresh Kumar Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/greybus/connection.c b/drivers/staging/greybus/connection.c index 32f1ec55b48f..4515bcd9dac8 100644 --- a/drivers/staging/greybus/connection.c +++ b/drivers/staging/greybus/connection.c @@ -226,11 +226,10 @@ void gb_connection_destroy(struct gb_connection *connection) return; /* XXX Need to wait for any outstanding requests to complete */ - WARN_ON(!list_empty(&connection->operations)); - - list_for_each_entry_safe(operation, next, &connection->operations, - links) { - gb_operation_cancel(operation); + if (WARN_ON(!list_empty(&connection->operations))) { + list_for_each_entry_safe(operation, next, + &connection->operations, links) + gb_operation_cancel(operation); } spin_lock_irq(&gb_connections_lock); list_del(&connection->interface_links);