From: Dan Carpenter Date: Tue, 5 Jan 2016 09:56:37 +0000 (+0300) Subject: gpio: pxa: checking IS_ERR() instead of NULL X-Git-Tag: v4.5-rc1~78^2~136 X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=41d107ad92b4b8abf103b62269c34da80320f212;p=linux.git gpio: pxa: checking IS_ERR() instead of NULL irq_domain_add_legacy() returns NULL on error, it doesn't return error pointers. Fixes: 384ca3c6a28d ('gpio: pxa: change the interrupt management') Signed-off-by: Dan Carpenter Signed-off-by: Linus Walleij --- diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c index c2d1a47ae784..415852d3ca8a 100644 --- a/drivers/gpio/gpio-pxa.c +++ b/drivers/gpio/gpio-pxa.c @@ -646,8 +646,8 @@ static int pxa_gpio_probe(struct platform_device *pdev) pchip->irqdomain = irq_domain_add_legacy(pdev->dev.of_node, pxa_last_gpio + 1, irq_base, 0, &pxa_irq_domain_ops, pchip); - if (IS_ERR(pchip->irqdomain)) - return PTR_ERR(pchip->irqdomain); + if (!pchip->irqdomain) + return -ENOMEM; irq0 = platform_get_irq_byname(pdev, "gpio0"); irq1 = platform_get_irq_byname(pdev, "gpio1");