From: Colin Ian King Date: Tue, 8 Aug 2017 09:52:32 +0000 (+0100) Subject: net: phy: mdio-bcm-unimac: fix unsigned wrap-around when decrementing timeout X-Git-Tag: v4.14-rc1~130^2~317 X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=51ce3e2145cc3927c9551b8c3623610114b41651;p=linux.git net: phy: mdio-bcm-unimac: fix unsigned wrap-around when decrementing timeout Change post-decrement compare to pre-decrement to avoid an unsigned integer wrap-around on timeout. This leads to the following !timeout check to never to be true so -ETIMEDOUT is never returned. Detected by CoverityScan, CID#1452623 ("Logically dead code") Fixes: 69a60b0579a4 ("net: phy: mdio-bcm-unimac: factor busy polling loop") Signed-off-by: Colin Ian King Signed-off-by: David S. Miller --- diff --git a/drivers/net/phy/mdio-bcm-unimac.c b/drivers/net/phy/mdio-bcm-unimac.c index 89425ca48412..73c5267a11fd 100644 --- a/drivers/net/phy/mdio-bcm-unimac.c +++ b/drivers/net/phy/mdio-bcm-unimac.c @@ -71,7 +71,7 @@ static int unimac_mdio_poll(void *wait_func_data) return 0; usleep_range(1000, 2000); - } while (timeout--); + } while (--timeout); if (!timeout) return -ETIMEDOUT;