From: Jens Lehmann Date: Fri, 9 Apr 2010 20:08:35 +0000 (+0200) Subject: Let check_preimage() use memset() to initialize "struct checkout" X-Git-Tag: v1.7.1-rc1~3^2 X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=54fd955c211db6f4a2c91301f792ec9de86eed31;p=git.git Let check_preimage() use memset() to initialize "struct checkout" Every code site except check_preimage() uses either memset() or declares a static instance of "struct checkout" to achieve proper initialization. Lets use memset() instead of explicit initialization of all members here too to be on the safe side in case this structure is expanded someday. Signed-off-by: Jens Lehmann Signed-off-by: Junio C Hamano --- diff --git a/builtin-apply.c b/builtin-apply.c index 7ca90472c..771c972c5 100644 --- a/builtin-apply.c +++ b/builtin-apply.c @@ -2824,11 +2824,8 @@ static int check_preimage(struct patch *patch, struct cache_entry **ce, struct s if (stat_ret < 0) { struct checkout costate; /* checkout */ + memset(&costate, 0, sizeof(costate)); costate.base_dir = ""; - costate.base_dir_len = 0; - costate.force = 0; - costate.quiet = 0; - costate.not_new = 0; costate.refresh_cache = 1; if (checkout_entry(*ce, &costate, NULL) || lstat(old_name, st))