From: Tejun Heo <tj@kernel.org>
Date: Thu, 4 Jun 2015 21:20:51 +0000 (+0900)
Subject: bdi: fix wrong error return value in cgwb_create()
X-Git-Tag: v4.2-rc1~113^2~4
X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=5857cd637bc0d60dc7e37af396b01324f199d89b;p=linux.git

bdi: fix wrong error return value in cgwb_create()

On wb_congested_get_create() failure, cgwb_create() forgot to set @ret
to -ENOMEM ending up returning 0.  Fix it so that it returns -ENOMEM.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
---

diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index 887d72a85b5e..436bb53dd383 100644
--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -554,8 +554,10 @@ static int cgwb_create(struct backing_dev_info *bdi,
 		goto err_ref_exit;
 
 	wb->congested = wb_congested_get_create(bdi, blkcg_css->id, gfp);
-	if (!wb->congested)
+	if (!wb->congested) {
+		ret = -ENOMEM;
 		goto err_fprop_exit;
+	}
 
 	wb->memcg_css = memcg_css;
 	wb->blkcg_css = blkcg_css;