From: Jacob Nevins <jacobn@chiark.greenend.org.uk>
Date: Thu, 23 Apr 2015 22:42:45 +0000 (+0100)
Subject: Old Dropbear servers have the ssh-close-vs-request bug.
X-Git-Tag: 0.65~25
X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=5ac299449e188e120fc06a6fd59d5f97840245b0;hp=2856422eab2169928a44ebbf00e8b8d8ad7e5916;p=PuTTY.git

Old Dropbear servers have the ssh-close-vs-request bug.

Add automatic bug detection. (Versions verified by Matt Johnston.)

(cherry picked from commit 63dddfc00f4ca44f8cc0a372b419e0ff45008ea2)
---

diff --git a/ssh.c b/ssh.c
index 6009e06f..13b67b6b 100644
--- a/ssh.c
+++ b/ssh.c
@@ -2817,11 +2817,15 @@ static void ssh_detect_bugs(Ssh ssh, char *vstring)
     if (conf_get_int(ssh->conf, CONF_sshbug_chanreq) == FORCE_ON ||
 	(conf_get_int(ssh->conf, CONF_sshbug_chanreq) == AUTO &&
 	 (wc_match("OpenSSH_[2-5].*", imp) ||
-	  wc_match("OpenSSH_6.[0-6]*", imp)))) {
+	  wc_match("OpenSSH_6.[0-6]*", imp) ||
+	  wc_match("dropbear_0.[2-4][0-9]*", imp) ||
+	  wc_match("dropbear_0.5[01]*", imp)))) {
 	/*
-	 * These versions have the SSH-2 channel request bug. 6.7 and
-	 * above do not:
+	 * These versions have the SSH-2 channel request bug.
+	 * OpenSSH 6.7 and above do not:
 	 * https://bugzilla.mindrot.org/show_bug.cgi?id=1818
+	 * dropbear_0.52 and above do not:
+	 * https://secure.ucc.asn.au/hg/dropbear/rev/cd02449b709c
 	 */
 	ssh->remote_bugs |= BUG_SENDS_LATE_REQUEST_REPLY;
 	logevent("We believe remote version has SSH-2 channel request bug");