From: Jean Delvare Date: Mon, 8 Jul 2013 12:18:24 +0000 (+0200) Subject: hwmon: (lm63) Drop redundant safety on cache lifetime X-Git-Tag: v3.11-rc1~54^2 X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=5b0620df9c38438ee245a97b8102ed74556e5505;p=linux.git hwmon: (lm63) Drop redundant safety on cache lifetime time_after (as opposed to time_after_equal) already ensures that the cache lifetime is at least as much as requested. There is no point in manually adding another jiffy to that value, and this can confuse the reader into wrong interpretation. Signed-off-by: Jean Delvare Cc: Imre Deak --- diff --git a/drivers/hwmon/lm63.c b/drivers/hwmon/lm63.c index f644a2e57599..d0def50ea860 100644 --- a/drivers/hwmon/lm63.c +++ b/drivers/hwmon/lm63.c @@ -247,9 +247,8 @@ static struct lm63_data *lm63_update_device(struct device *dev) mutex_lock(&data->update_lock); - next_update = data->last_updated - + msecs_to_jiffies(data->update_interval) + 1; - + next_update = data->last_updated + + msecs_to_jiffies(data->update_interval); if (time_after(jiffies, next_update) || !data->valid) { if (data->config & 0x04) { /* tachometer enabled */ /* order matters for fan1_input */