From: Niklas Söderlund Date: Wed, 1 Feb 2017 14:41:54 +0000 (+0100) Subject: sh_eth: align usage of sh_eth_modify() with rest of driver X-Git-Tag: v4.11-rc1~124^2~263^2~1 X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=5e2ed1329ee074229d5a2f4389035be818120980;p=linux.git sh_eth: align usage of sh_eth_modify() with rest of driver To be consistent with the rest of the driver when setting bits using sh_eth_modify() the same bit should also be cleared. This have no functional change and should have been done from the start. Signed-off-by: Niklas Söderlund Suggested-by: Sergei Shtylyov Acked-by: Sergei Shtylyov Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index 2f08d2735fe2..f9134c818ac6 100644 --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c @@ -3271,7 +3271,7 @@ static int sh_eth_wol_setup(struct net_device *ndev) sh_eth_write(ndev, EESIPR_ECIIP, EESIPR); /* Enable MagicPacket */ - sh_eth_modify(ndev, ECMR, 0, ECMR_MPDE); + sh_eth_modify(ndev, ECMR, ECMR_MPDE, ECMR_MPDE); /* Increased clock usage so device won't be suspended */ clk_enable(mdp->clk);