From: Alex Elder Date: Tue, 24 May 2016 18:34:49 +0000 (-0500) Subject: greybus: eliminate unneeded null check X-Git-Tag: v4.9-rc1~119^2~378^2~21^2~333 X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=66394300c37e9321a913f269021b3d6c92d786ad;p=linux.git greybus: eliminate unneeded null check Coccinelle points out that debugfs_remove_recursive() handles a null argument properly, so there's no need to check for NULL before making the call. I have verified this is true of the kernel we're now working with (arche-6.0). Signed-off-by: Alex Elder Reviewed-by: Viresh Kumar Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c index dda871912c10..d5496f8a7b89 100644 --- a/drivers/staging/greybus/camera.c +++ b/drivers/staging/greybus/camera.c @@ -883,8 +883,7 @@ static int gb_camera_debugfs_init(struct gb_camera *gcam) static void gb_camera_debugfs_cleanup(struct gb_camera *gcam) { - if (gcam->debugfs.root) - debugfs_remove_recursive(gcam->debugfs.root); + debugfs_remove_recursive(gcam->debugfs.root); vfree(gcam->debugfs.buffers); }