From: David Kershner <david.kershner@unisys.com>
Date: Mon, 21 Nov 2016 17:15:49 +0000 (-0500)
Subject: staging: unisys: visorbus: bus_responder add error handling
X-Git-Tag: v4.10-rc1~148^2~115
X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=734ad93a23a8017e9256f717530e2e4f9c654ce2;p=linux.git

staging: unisys: visorbus: bus_responder add error handling

Controlvm_respond now returns an error. Add error handling to the
bus_responder function.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
index 034ff91ead5d..a10e41aa5d62 100644
--- a/drivers/staging/unisys/visorbus/visorchipset.c
+++ b/drivers/staging/unisys/visorbus/visorchipset.c
@@ -638,18 +638,18 @@ save_crash_message(struct controlvm_message *msg, enum crash_obj_type typ)
 	return 0;
 }
 
-static void
+static int
 bus_responder(enum controlvm_id cmd_id,
 	      struct controlvm_message_header *pending_msg_hdr,
 	      int response)
 {
 	if (!pending_msg_hdr)
-		return;		/* no controlvm response needed */
+		return -EIO;
 
 	if (pending_msg_hdr->id != (u32)cmd_id)
-		return;
+		return -EINVAL;
 
-	controlvm_respond(pending_msg_hdr, response);
+	return controlvm_respond(pending_msg_hdr, response);
 }
 
 static void