From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Date: Wed, 12 Mar 2014 15:50:45 +0000 (+0100)
Subject: mfd: tps65910: Fix regmap_irq_chip_data leak on mfd_add_devices fail
X-Git-Tag: v3.15-rc1~64^2~6
X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=742766aac563ea1c28e9f86ed53db757a2872081;p=linux.git

mfd: tps65910: Fix regmap_irq_chip_data leak on mfd_add_devices fail

The tps65910_i2c_probe() allocates regmap_irq_chip in
tps65910_irq_init() but it does not clean this up in case of
mfd_add_devices() failure.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---

diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
index d6573318977f..460a014ca629 100644
--- a/drivers/mfd/tps65910.c
+++ b/drivers/mfd/tps65910.c
@@ -511,6 +511,7 @@ static int tps65910_i2c_probe(struct i2c_client *i2c,
 			      regmap_irq_get_domain(tps65910->irq_data));
 	if (ret < 0) {
 		dev_err(&i2c->dev, "mfd_add_devices failed: %d\n", ret);
+		tps65910_irq_exit(tps65910);
 		return ret;
 	}