From: Eric Wong <normalperson@yhbt.net>
Date: Thu, 15 Feb 2007 02:38:46 +0000 (-0800)
Subject: git-svn: error checking for invalid [svn-remote "..."] sections
X-Git-Tag: v1.5.1-rc1~161
X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=7447b4bc837d2f73fb4cd34f2a44a0cb120c5c39;p=git.git

git-svn: error checking for invalid [svn-remote "..."] sections

We don't end up trying to pass an undef URL over to SVN::Ra->new
because it'll segfault.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
---

diff --git a/git-svn.perl b/git-svn.perl
index ace31021e..201418e09 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -753,9 +753,10 @@ sub parse_revision_argument {
 
 sub fetch_all {
 	my ($repo_id, $remotes) = @_;
-	my $remote = $remotes->{$repo_id};
+	my $remote = $remotes->{$repo_id} or
+	             die "[svn-remote \"$repo_id\"] unknown\n";
 	my $fetch = $remote->{fetch};
-	my $url = $remote->{url};
+	my $url = $remote->{url} or die "svn-remote.$repo_id.url not defined\n";
 	my (@gs, @globs);
 	my $ra = Git::SVN::Ra->new($url);
 	my $uuid = $ra->get_uuid;