From: Arnd Bergmann Date: Thu, 16 Sep 2010 13:35:54 +0000 (+0200) Subject: BKL: Remove BKL from afs X-Git-Tag: v2.6.37-rc1~174^2~11 X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=77f2fe036cd51300c80d1aca76bcf23a09977f13;p=linux.git BKL: Remove BKL from afs The BKL is only used in put_super and fill_super, which are both protected by the superblocks s_umount rw_semaphore. Therefore it is safe to remove the BKL entirely. Signed-off-by: Arnd Bergmann Cc: linux-afs@lists.infradead.org Cc: David Howells --- diff --git a/fs/afs/super.c b/fs/afs/super.c index 6c2fef44d385..eacf76d98ae0 100644 --- a/fs/afs/super.c +++ b/fs/afs/super.c @@ -19,7 +19,6 @@ #include #include #include -#include #include #include #include @@ -302,15 +301,12 @@ static int afs_fill_super(struct super_block *sb, void *data) struct inode *inode = NULL; int ret; - lock_kernel(); - _enter(""); /* allocate a superblock info record */ as = kzalloc(sizeof(struct afs_super_info), GFP_KERNEL); if (!as) { _leave(" = -ENOMEM"); - unlock_kernel(); return -ENOMEM; } @@ -344,7 +340,6 @@ static int afs_fill_super(struct super_block *sb, void *data) sb->s_root = root; _leave(" = 0"); - unlock_kernel(); return 0; error_inode: @@ -358,7 +353,6 @@ static int afs_fill_super(struct super_block *sb, void *data) sb->s_fs_info = NULL; _leave(" = %d", ret); - unlock_kernel(); return ret; } @@ -458,12 +452,8 @@ static void afs_put_super(struct super_block *sb) _enter(""); - lock_kernel(); - afs_put_volume(as->volume); - unlock_kernel(); - _leave(""); }