From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 15 Jan 2017 10:20:13 +0000 (+0100)
Subject: selinux: Return directly after a failed kzalloc() in perm_read()
X-Git-Tag: v4.12-rc1~123^2~6^2~7
X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=7befb7514e5d53026e9fe4a6548f118a65a20a4f;p=linux.git

selinux: Return directly after a failed kzalloc() in perm_read()

Return directly after a call of the function "kzalloc" failed
at the beginning.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Paul Moore <paul@paul-moore.com>
---

diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c
index 99ee0ee2d92a..5ca2d26ecf7f 100644
--- a/security/selinux/ss/policydb.c
+++ b/security/selinux/ss/policydb.c
@@ -1118,10 +1118,9 @@ static int perm_read(struct policydb *p, struct hashtab *h, void *fp)
 	__le32 buf[2];
 	u32 len;
 
-	rc = -ENOMEM;
 	perdatum = kzalloc(sizeof(*perdatum), GFP_KERNEL);
 	if (!perdatum)
-		goto bad;
+		return -ENOMEM;
 
 	rc = next_entry(buf, fp, sizeof buf);
 	if (rc)