From: Aishwarya Pant Date: Fri, 10 Mar 2017 16:39:11 +0000 (+0530) Subject: staging: bcm2835-audio: remove anonymous field declarations X-Git-Tag: v4.12-rc1~84^2~592 X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=7ebe438c64385edaeb4d26e9707991e4819914d2;p=linux.git staging: bcm2835-audio: remove anonymous field declarations Anonymous field declarations are error prone. This patch replaces anonymous declarations with explicit field declarations for typedef SERVICE_CREATION_T in vc_vchi_audio_init(..) Signed-off-by: Aishwarya Pant Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c index c54bef351dc1..d8a8e91d824e 100644 --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c @@ -302,16 +302,16 @@ vc_vchi_audio_init(VCHI_INSTANCE_T vchi_instance, /* Open the VCHI service connections */ for (i = 0; i < num_connections; i++) { SERVICE_CREATION_T params = { - VCHI_VERSION_EX(VC_AUDIOSERV_VER, VC_AUDIOSERV_MIN_VER), - VC_AUDIO_SERVER_NAME, // 4cc service code - vchi_connections[i], // passed in fn pointers - 0, // rx fifo size (unused) - 0, // tx fifo size (unused) - audio_vchi_callback, // service callback - instance, // service callback parameter - 1, //TODO: remove VCOS_FALSE, // unaligned bulk receives - 1, //TODO: remove VCOS_FALSE, // unaligned bulk transmits - 0 // want crc check on bulk transfers + .version = VCHI_VERSION_EX(VC_AUDIOSERV_VER, VC_AUDIOSERV_MIN_VER), + .service_id = VC_AUDIO_SERVER_NAME, + .connection = vchi_connections[i], + .rx_fifo_size = 0, + .tx_fifo_size = 0, + .callback = audio_vchi_callback, + .callback_param = instance, + .want_unaligned_bulk_rx = 1, //TODO: remove VCOS_FALSE + .want_unaligned_bulk_tx = 1, //TODO: remove VCOS_FALSE + .want_crc = 0 }; LOG_DBG("%s: about to open %i\n", __func__, i);