From: Kevin 'ldir' Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
Date: Thu, 30 May 2019 17:10:43 +0000 (+0000)
Subject: net: sched: act_ctinfo: minor size optimisation
X-Git-Tag: v5.3-rc1~140^2~379
X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=84a32edec48056131c91bebb706c2a0a5976a1a1;p=linux.git

net: sched: act_ctinfo: minor size optimisation

Since the new parameter block is initialised to 0 by kzmalloc we don't
need to mask & clear unused operational mode bits, they are already
unset.

Drop the pointless code.

Signed-off-by: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/sched/act_ctinfo.c b/net/sched/act_ctinfo.c
index 926109139a81..e78b60e47c0f 100644
--- a/net/sched/act_ctinfo.c
+++ b/net/sched/act_ctinfo.c
@@ -231,16 +231,12 @@ static int tcf_ctinfo_init(struct net *net, struct nlattr *nla,
 		cp_new->dscpmaskshift = dscpmaskshift;
 		cp_new->dscpstatemask = dscpstatemask;
 		cp_new->mode |= CTINFO_MODE_DSCP;
-	} else {
-		cp_new->mode &= ~CTINFO_MODE_DSCP;
 	}
 
 	if (tb[TCA_CTINFO_PARMS_CPMARK_MASK]) {
 		cp_new->cpmarkmask =
 				nla_get_u32(tb[TCA_CTINFO_PARMS_CPMARK_MASK]);
 		cp_new->mode |= CTINFO_MODE_CPMARK;
-	} else {
-		cp_new->mode &= ~CTINFO_MODE_CPMARK;
 	}
 
 	spin_lock_bh(&ci->tcf_lock);