From: Eric Biggers <ebiggers@google.com>
Date: Tue, 17 Jul 2018 17:36:04 +0000 (-0700)
Subject: security: check for kstrdup() failure in lsm_append()
X-Git-Tag: v4.19-rc1~149^2
X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=87ea58433208d17295e200d56be5e2a4fe4ce7d6;p=linux.git

security: check for kstrdup() failure in lsm_append()

lsm_append() should return -ENOMEM if memory allocation failed.

Fixes: d69dece5f5b6 ("LSM: Add /sys/kernel/security/lsm")
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: James Morris <james.morris@microsoft.com>
---

diff --git a/security/security.c b/security/security.c
index 6e149d0ffe33..b49ee810371b 100644
--- a/security/security.c
+++ b/security/security.c
@@ -118,6 +118,8 @@ static int lsm_append(char *new, char **result)
 
 	if (*result == NULL) {
 		*result = kstrdup(new, GFP_KERNEL);
+		if (*result == NULL)
+			return -ENOMEM;
 	} else {
 		/* Check if it is the last registered name */
 		if (match_last_lsm(*result, new))