From: David Henningsson <david.henningsson@canonical.com>
Date: Fri, 18 Jan 2013 14:43:02 +0000 (+0100)
Subject: ALSA: hda - don't compare with yourself in fill_input_pin_labels
X-Git-Tag: v3.9-rc1~129^2~70^2~23
X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=8e8db7f123dcc4d56464fc584667c8f9ae9f4aef;p=linux.git

ALSA: hda - don't compare with yourself in fill_input_pin_labels

Just stumbled over this one while reading the code.

Signed-off-by: David Henningsson <david.henningsson@canonical.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/pci/hda/hda_generic.c b/sound/pci/hda/hda_generic.c
index 10b14a925ddb..e4e71fa8d87c 100644
--- a/sound/pci/hda/hda_generic.c
+++ b/sound/pci/hda/hda_generic.c
@@ -2558,7 +2558,7 @@ static int fill_input_pin_labels(struct hda_codec *codec)
 
 		label = hda_get_autocfg_input_label(codec, cfg, i);
 		idx = 0;
-		for (j = i; j >= 0; j--) {
+		for (j = i - 1; j >= 0; j--) {
 			if (spec->input_labels[j] &&
 			    !strcmp(spec->input_labels[j], label)) {
 				idx = spec->input_label_idxs[j] + 1;