From: Monam Agarwal Date: Sun, 23 Mar 2014 19:22:43 +0000 (+0530) Subject: net/openvswitch: Use with RCU_INIT_POINTER(x, NULL) in vport-gre.c X-Git-Tag: v3.16-rc1~27^2~201^2 X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=944df8ae84d88f5e8eb027990dad2cfa4fbe4be5;p=linux.git net/openvswitch: Use with RCU_INIT_POINTER(x, NULL) in vport-gre.c This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL) The rcu_assign_pointer() ensures that the initialization of a structure is carried out before storing a pointer to that structure. And in the case of the NULL pointer, there is no structure to initialize. So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL) Signed-off-by: Monam Agarwal Signed-off-by: Jesse Gross --- diff --git a/net/openvswitch/vport-gre.c b/net/openvswitch/vport-gre.c index 0856f014d7a9..35ec4fed09e2 100644 --- a/net/openvswitch/vport-gre.c +++ b/net/openvswitch/vport-gre.c @@ -256,7 +256,7 @@ static void gre_tnl_destroy(struct vport *vport) ovs_net = net_generic(net, ovs_net_id); - rcu_assign_pointer(ovs_net->vport_net.gre_vport, NULL); + RCU_INIT_POINTER(ovs_net->vport_net.gre_vport, NULL); ovs_vport_deferred_free(vport); gre_exit(); }