From: Alexey Khoroshilov Date: Wed, 7 May 2014 20:26:52 +0000 (+0400) Subject: usb: gadget: gr_udc: unconditionally use GFP_ATOMIC in gr_queue_ext() X-Git-Tag: v3.16-rc1~30^2~34^2~171^2~23 X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=966036fde60e6d96708815e0d495692ac352acf9;p=linux.git usb: gadget: gr_udc: unconditionally use GFP_ATOMIC in gr_queue_ext() As far as gr_queue() is called with spinlock held, we have to pass GFP_ATOMIC regardless of gfp argument. Found by Linux Driver Verification project (linuxtesting.org). Acked-by: Andreas Larsson Signed-off-by: Alexey Khoroshilov Signed-off-by: Felipe Balbi --- diff --git a/drivers/usb/gadget/gr_udc.c b/drivers/usb/gadget/gr_udc.c index 4966971d6978..99a37ed03e27 100644 --- a/drivers/usb/gadget/gr_udc.c +++ b/drivers/usb/gadget/gr_udc.c @@ -1684,7 +1684,7 @@ static int gr_queue_ext(struct usb_ep *_ep, struct usb_request *_req, if (ep->is_in) gr_dbgprint_request("EXTERN", ep, req); - ret = gr_queue(ep, req, gfp_flags); + ret = gr_queue(ep, req, GFP_ATOMIC); spin_unlock(&ep->dev->lock);