From: Tom St Denis Date: Tue, 16 May 2017 14:22:00 +0000 (-0400) Subject: drm/amd/display: Tidy up dce120_timing_generator_enable_advanced_request() X-Git-Tag: v4.15-rc1~56^2~23^2~480 X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=a4b0a5b84827b1bceb99c3c2aa354073cc5bfb53;p=linux.git drm/amd/display: Tidy up dce120_timing_generator_enable_advanced_request() Simplify the function by removing identical looking code blocks. Signed-off-by: Tom St Denis Reviewed-by: Harry Wentland Signed-off-by: Alex Deucher --- diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_timing_generator.c b/drivers/gpu/drm/amd/display/dc/dce120/dce120_timing_generator.c index dc8eeac6ac96..13cc0d49e007 100644 --- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_timing_generator.c +++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_timing_generator.c @@ -669,36 +669,23 @@ void dce120_timing_generator_enable_advanced_request( mmCRTC0_CRTC_START_LINE_CONTROL, tg110->offsets.crtc); - - if (enable) { - set_reg_field_value( - value, - 0, - CRTC0_CRTC_START_LINE_CONTROL, - CRTC_LEGACY_REQUESTOR_EN); - } else { - set_reg_field_value( - value, - 1, - CRTC0_CRTC_START_LINE_CONTROL, - CRTC_LEGACY_REQUESTOR_EN); - } + set_reg_field_value( + value, + enable ? 0 : 1, + CRTC0_CRTC_START_LINE_CONTROL, + CRTC_LEGACY_REQUESTOR_EN); /* Program advanced line position acc.to the best case from fetching data perspective to hide MC latency * and prefilling Line Buffer in V Blank (to 10 lines as LB can store max 10 lines) */ if (v_sync_width_and_b_porch > 10) - set_reg_field_value( - value, - 10, - CRTC0_CRTC_START_LINE_CONTROL, - CRTC_ADVANCED_START_LINE_POSITION); - else - set_reg_field_value( - value, - v_sync_width_and_b_porch, - CRTC0_CRTC_START_LINE_CONTROL, - CRTC_ADVANCED_START_LINE_POSITION); + v_sync_width_and_b_porch = 10; + + set_reg_field_value( + value, + v_sync_width_and_b_porch, + CRTC0_CRTC_START_LINE_CONTROL, + CRTC_ADVANCED_START_LINE_POSITION); dm_write_reg_soc15(tg->ctx, mmCRTC0_CRTC_START_LINE_CONTROL,