From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 29 Dec 2015 11:32:41 +0000 (-0200)
Subject: [media] msi2500: Delete an unnecessary check in msi2500_set_usb_adc()
X-Git-Tag: v4.6-rc1~130^2^2~343
X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=a73cfe527c10bb023f0e22dd8cf37dd418c093e7;p=linux.git

[media] msi2500: Delete an unnecessary check in msi2500_set_usb_adc()

This issue was detected by using the Coccinelle software.

Return the value from a call of the msi2500_ctrl_msg() function
without using an extra check for the variable "ret" at the end.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
---

diff --git a/drivers/media/usb/msi2500/msi2500.c b/drivers/media/usb/msi2500/msi2500.c
index c104315fdc17..2d33033682af 100644
--- a/drivers/media/usb/msi2500/msi2500.c
+++ b/drivers/media/usb/msi2500/msi2500.c
@@ -839,8 +839,6 @@ static int msi2500_set_usb_adc(struct msi2500_dev *dev)
 		goto err;
 
 	ret = msi2500_ctrl_msg(dev, CMD_WREG, reg3);
-	if (ret)
-		goto err;
 err:
 	return ret;
 }