From: Franklin S Cooper Jr Date: Fri, 16 Oct 2015 15:29:03 +0000 (-0500) Subject: spi: Setup the master controller driver before setting the chipselect X-Git-Tag: v4.4-rc1~113^2~10^2 X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=abeedb0159eec42c52a28fc44457164f71aa12a9;p=linux.git spi: Setup the master controller driver before setting the chipselect SPI controllers may need to be properly setup before chip selects can be used. Therefore, wait until the spi controller has a chance to perform their setup procedure before trying to use the chip select. This also insures that the chip selects pins are in a good state before asseting them which otherwise may cause confusion. Signed-off-by: Franklin S Cooper Jr Tested-by: Grygorii Strashko Tested-by: Ivan Khoronzhuk Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 3abb3903f2ad..7b528b0aedb9 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -1993,11 +1993,11 @@ int spi_setup(struct spi_device *spi) if (!spi->max_speed_hz) spi->max_speed_hz = spi->master->max_speed_hz; - spi_set_cs(spi, false); - if (spi->master->setup) status = spi->master->setup(spi); + spi_set_cs(spi, false); + dev_dbg(&spi->dev, "setup mode %d, %s%s%s%s%u bits/w, %u Hz max --> %d\n", (int) (spi->mode & (SPI_CPOL | SPI_CPHA)), (spi->mode & SPI_CS_HIGH) ? "cs_high, " : "",