From: Simon Tatham <anakin@pobox.com>
Date: Tue, 14 Feb 2017 20:26:03 +0000 (+0000)
Subject: uxpgnt: fix an uninitialised structure field in find_key().
X-Git-Tag: 0.68~28
X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=b6b52269e1085d9a58adf2f0f86f96fd96fa3199;p=PuTTY.git

uxpgnt: fix an uninitialised structure field in find_key().

Thanks, Coverity - I must have been lucky that Unix Pageant in client
mode hasn't so far happened to have this field come out non-NULL, or
else pageant_pubkey_copy would have tried to dupstr a garbage pointer.
---

diff --git a/unix/uxpgnt.c b/unix/uxpgnt.c
index d0d69600..a4bc6b93 100644
--- a/unix/uxpgnt.c
+++ b/unix/uxpgnt.c
@@ -551,6 +551,7 @@ struct pageant_pubkey *find_key(const char *string, char **retstr)
              * list things.
              */
             key_in.ssh_version = 1;
+            key_in.comment = NULL;
             key_ret = pageant_pubkey_copy(&key_in);
             sfree(key_in.blob);
             filename_free(fn);
@@ -577,6 +578,7 @@ struct pageant_pubkey *find_key(const char *string, char **retstr)
              * list things.
              */
             key_in.ssh_version = 2;
+            key_in.comment = NULL;
             key_ret = pageant_pubkey_copy(&key_in);
             sfree(key_in.blob);
             filename_free(fn);