From: Daniel Wagner Date: Tue, 13 Sep 2016 08:58:49 +0000 (+0200) Subject: scsi: sym53c8xx_2: Use complete() instead complete_all() X-Git-Tag: v4.9-rc1~95^2~35 X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=ba2f1293e95f071156f5a6660fb2316d4ea15c46;p=linux.git scsi: sym53c8xx_2: Use complete() instead complete_all() There is only one waiter for the completion, therefore there is no need to use complete_all(). Let's make that clear by using complete() instead of complete_all(). The usage pattern of the completion is: waiter context waker context sym_eh_handler() struct completion eh_done init_completion(eh_done) pci_channel_offline() wait_for_completion_timeout(eh_done) sym2_io_resume() complete(eh_done) Signed-off-by: Daniel Wagner Reviewed-by: Christoph Hellwig Signed-off-by: Martin K. Petersen --- diff --git a/drivers/scsi/sym53c8xx_2/sym_glue.c b/drivers/scsi/sym53c8xx_2/sym_glue.c index 5d00e514ff28..d32e3ba8863e 100644 --- a/drivers/scsi/sym53c8xx_2/sym_glue.c +++ b/drivers/scsi/sym53c8xx_2/sym_glue.c @@ -1874,7 +1874,7 @@ static void sym2_io_resume(struct pci_dev *pdev) spin_lock_irq(shost->host_lock); if (sym_data->io_reset) - complete_all(sym_data->io_reset); + complete(sym_data->io_reset); spin_unlock_irq(shost->host_lock); }