From: David Howells <dhowells@redhat.com>
Date: Wed, 1 May 2019 12:27:09 +0000 (+0100)
Subject: afs: Fix the afs.cell and afs.volume xattr handlers
X-Git-Tag: v5.2-rc1~138^2~5
X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=c73aa4102f5b9f261a907c3b3df94cd2c478504d;p=linux.git

afs: Fix the afs.cell and afs.volume xattr handlers

Fix the ->get handlers for the afs.cell and afs.volume xattrs to pass the
source data size to memcpy() rather than target buffer size.

Overcopying the source data occasionally causes the kernel to oops.

Fixes: d3e3b7eac886 ("afs: Add metadata xattrs")
Signed-off-by: David Howells <dhowells@redhat.com>
---

diff --git a/fs/afs/xattr.c b/fs/afs/xattr.c
index a2cdf25573e2..4ea7e53752dc 100644
--- a/fs/afs/xattr.c
+++ b/fs/afs/xattr.c
@@ -50,7 +50,7 @@ static int afs_xattr_get_cell(const struct xattr_handler *handler,
 		return namelen;
 	if (namelen > size)
 		return -ERANGE;
-	memcpy(buffer, cell->name, size);
+	memcpy(buffer, cell->name, namelen);
 	return namelen;
 }
 
@@ -104,7 +104,7 @@ static int afs_xattr_get_volume(const struct xattr_handler *handler,
 		return namelen;
 	if (namelen > size)
 		return -ERANGE;
-	memcpy(buffer, volname, size);
+	memcpy(buffer, volname, namelen);
 	return namelen;
 }