From: Frank Rowand Date: Sat, 14 Mar 2015 07:04:24 +0000 (-0700) Subject: of/unittest: breadcrumbs to reduce pain of future maintainers X-Git-Tag: v4.1-rc1~90^2~3 X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=c8547119ce54ef6d3c0685ef3837514fa6e11d28;p=linux.git of/unittest: breadcrumbs to reduce pain of future maintainers Fix warnings pointed out by checkpatch. Checkpatch warns: externs should be avoided in .c files Reducing pain for future maintainers - adding a comment so that anyone trying to find where the extern data is created will be able to find it. (grep will not find that location) Signed-off-by: Frank Rowand Signed-off-by: Grant Likely --- diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index 9ecf8529fe29..9e4e401ff21d 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -878,6 +878,10 @@ static int __init selftest_data_add(void) { void *selftest_data; struct device_node *selftest_data_node, *np; + /* + * __dtb_testcases_begin[] and __dtb_testcases_end[] are magically + * created by cmd_dt_S_dtb in scripts/Makefile.lib + */ extern uint8_t __dtb_testcases_begin[]; extern uint8_t __dtb_testcases_end[]; const int size = __dtb_testcases_end - __dtb_testcases_begin;