From: kbuild test robot Date: Fri, 11 Nov 2016 15:31:46 +0000 (+0800) Subject: staging: vc04_services: fix ifnullfree.cocci warnings X-Git-Tag: v4.10-rc1~148^2~282 X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=caac19b97d4745ff1ec1bbd0b72cbf769c96079d;p=linux.git staging: vc04_services: fix ifnullfree.cocci warnings drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c:65:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci Signed-off-by: Fengguang Wu Reviewed-by: Eric Anholt Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c index 384acb8d2eae..f76f4d790532 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c @@ -61,8 +61,7 @@ int vchiu_queue_init(VCHIU_QUEUE_T *queue, int size) void vchiu_queue_delete(VCHIU_QUEUE_T *queue) { - if (queue->storage != NULL) - kfree(queue->storage); + kfree(queue->storage); } int vchiu_queue_is_empty(VCHIU_QUEUE_T *queue)