From: Junio C Hamano <junkio@cox.net>
Date: Wed, 17 Jan 2007 19:13:02 +0000 (-0800)
Subject: git-format-patch: do not crash with format.headers without value.
X-Git-Tag: v1.5.0-rc2~50
X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=d7fb91c69dc347c53b0d9830b13fdadf217a78f1;p=git.git

git-format-patch: do not crash with format.headers without value.

An incorrect config file can say:

	[format]
		headers

and crash the parsing.

Signed-off-by: Junio C Hamano <junkio@cox.net>
---

diff --git a/builtin-log.c b/builtin-log.c
index 7397a5af0..1cd9d3f76 100644
--- a/builtin-log.c
+++ b/builtin-log.c
@@ -202,7 +202,11 @@ static const char *fmt_patch_suffix = ".txt";
 static int git_format_config(const char *var, const char *value)
 {
 	if (!strcmp(var, "format.headers")) {
-		int len = strlen(value);
+		int len;
+
+		if (!value)
+			die("format.headers without value");
+		len = strlen(value);
 		extra_headers_size += len + 1;
 		extra_headers = xrealloc(extra_headers, extra_headers_size);
 		extra_headers[extra_headers_size - len - 1] = 0;