From: Alex Elder <elder@linaro.org>
Date: Tue, 24 May 2016 18:34:50 +0000 (-0500)
Subject: greybus: fix pointless null check
X-Git-Tag: v4.9-rc1~119^2~378^2~21^2~332
X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=d97fca12e92d3179554baf4db42611e5fe56aeed;p=linux.git

greybus: fix pointless null check

Coccinelle points out that a call in gb_lights_channel_free() to
flush_work() is passed which is always non-null.   Prior to the
call, there is an unnecessary check to see if that address is null.
Get rid of the test.

Signed-off-by: Alex Elder <elder@linaro.org>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
---

diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c
index 8b71ed3df318..78fb8a9f6a48 100644
--- a/drivers/staging/greybus/light.c
+++ b/drivers/staging/greybus/light.c
@@ -1019,8 +1019,7 @@ static int gb_lights_light_register(struct gb_light *light)
 static void gb_lights_channel_free(struct gb_channel *channel)
 {
 #ifndef LED_HAVE_SET_BLOCKING
-	if (&channel->work_brightness_set)
-		flush_work(&channel->work_brightness_set);
+	flush_work(&channel->work_brightness_set);
 #endif
 	kfree(channel->attrs);
 	kfree(channel->attr_group);