From: Greg Kroah-Hartman Date: Tue, 18 Sep 2012 15:59:23 +0000 (+0100) Subject: USB: serial: io_ti: remove some remaining printk() calls X-Git-Tag: v3.7-rc1~171^2~33 X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=d9bb03dc89c1d63e307cb0bad60b5f6faa16af6f;p=linux.git USB: serial: io_ti: remove some remaining printk() calls Use dev_err() like the rest of that function does, and the rest of the driver does, to properly show what device and driver caused the problem. Cc: Johan Hovold Cc: "Eric W. Biederman" Cc: Rusty Russell Cc: Alan Stern Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/serial/io_ti.c b/drivers/usb/serial/io_ti.c index 631725454d73..21c7efa57acf 100644 --- a/drivers/usb/serial/io_ti.c +++ b/drivers/usb/serial/io_ti.c @@ -845,8 +845,8 @@ static int build_i2c_fw_hdr(__u8 *header, struct device *dev) err = request_firmware(&fw, fw_name, dev); if (err) { - printk(KERN_ERR "Failed to load image \"%s\" err %d\n", - fw_name, err); + dev_err(dev, "Failed to load image \"%s\" err %d\n", + fw_name, err); kfree(buffer); return err; } @@ -1404,8 +1404,8 @@ static int download_fw(struct edgeport_serial *serial) err = request_firmware(&fw, fw_name, dev); if (err) { - printk(KERN_ERR "Failed to load image \"%s\" err %d\n", - fw_name, err); + dev_err(dev, "Failed to load image \"%s\" err %d\n", + fw_name, err); kfree(buffer); return err; }