From: Tobin C. Harding <me@tobin.cc>
Date: Mon, 27 Feb 2017 03:14:48 +0000 (+1100)
Subject: staging: ks7010: refactor function call parameters
X-Git-Tag: v4.12-rc1~84^2~836
X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=dad5980e313ec44f87f6306cc9186ed50cfecc8a;p=linux.git

staging: ks7010: refactor function call parameters

Function call parameters are split over more lines than
necessary. Also assignment statements are split after the '=' sign.
This adds extra lines to the function and may also reduces
readability.

Refactor function call parameters and reduce the number of lines
used. Put assignment statements onto single line.

Signed-off-by: Tobin C. Harding <me@tobin.cc>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index 04130fb01842..14580cb4c755 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -195,48 +195,34 @@ static int _ks_wlan_hw_power_save(struct ks_wlan_private *priv)
 	if (!atomic_read(&priv->psstatus.confirm_wait) &&
 		!atomic_read(&priv->psstatus.snooze_guard) &&
 		!cnt_txqbody(priv)) {
-		retval =
-			ks7010_sdio_read(priv, INT_PENDING,
-					&rw_data,
-					sizeof(rw_data));
+		retval = ks7010_sdio_read(priv, INT_PENDING, &rw_data,
+					  sizeof(rw_data));
 		if (retval) {
-			DPRINTK(1,
-				" error : INT_PENDING=%02X\n",
-				rw_data);
+			DPRINTK(1, " error : INT_PENDING=%02X\n", rw_data);
 			queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,
-					&priv->ks_wlan_hw.rw_wq, 1);
+					   &priv->ks_wlan_hw.rw_wq, 1);
 			return 0;
 		}
 		if (!rw_data) {
 			rw_data = GCR_B_DOZE;
-			retval =
-				ks7010_sdio_write(priv,
-						GCR_B,
-						&rw_data,
-						sizeof(rw_data));
+			retval = ks7010_sdio_write(priv, GCR_B, &rw_data,
+						   sizeof(rw_data));
 			if (retval) {
-				DPRINTK(1,
-					" error : GCR_B=%02X\n",
-					rw_data);
-				queue_delayed_work
-					(priv->ks_wlan_hw.ks7010sdio_wq,
-						&priv->ks_wlan_hw.rw_wq, 1);
+				DPRINTK(1, " error : GCR_B=%02X\n", rw_data);
+				queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,
+						   &priv->ks_wlan_hw.rw_wq, 1);
 				return 0;
 			}
-			DPRINTK(4,
-				"PMG SET!! : GCR_B=%02X\n",
-				rw_data);
+			DPRINTK(4, "PMG SET!! : GCR_B=%02X\n", rw_data);
 			atomic_set(&priv->psstatus.status, PS_SNOOZE);
-			DPRINTK(3,
-				"psstatus.status=PS_SNOOZE\n");
+			DPRINTK(3, "psstatus.status=PS_SNOOZE\n");
 		} else {
 			queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,
-					&priv->ks_wlan_hw.rw_wq, 1);
+					   &priv->ks_wlan_hw.rw_wq, 1);
 		}
 	} else {
 		queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,
-				&priv->ks_wlan_hw.rw_wq,
-				0);
+				   &priv->ks_wlan_hw.rw_wq, 0);
 	}
 
 	return 0;