From: Stephen Boyd <stephen.boyd@linaro.org>
Date: Fri, 13 Oct 2017 07:44:51 +0000 (-0700)
Subject: of: unittest: Remove redundant OF_DETACHED flag setting
X-Git-Tag: v4.15-rc1~115^2~22
X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=e0f4145685ec7b477f6166ee819125107388a249;p=linux.git

of: unittest: Remove redundant OF_DETACHED flag setting

of_fdt_unflatten_tree() already sets the flag on the node to
OF_DETACHED, because of_fdt_unflatten_tree() calls
__unflatten_device_tree() with the detached bool set to true.

Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
Reviewed-by: Frank Rowand <frowand.list@gmail.com>
Signed-off-by: Rob Herring <robh@kernel.org>
---

diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 29a35cb1da64..add02cfbfb88 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -993,7 +993,6 @@ static int __init unittest_data_add(void)
 		pr_warn("%s: No tree to attach; not running tests\n", __func__);
 		return -ENODATA;
 	}
-	of_node_set_flag(unittest_data_node, OF_DETACHED);
 	rc = of_resolve_phandles(unittest_data_node);
 	if (rc) {
 		pr_err("%s: Failed to resolve phandles (rc=%i)\n", __func__, rc);
@@ -2143,7 +2142,6 @@ static int __init overlay_data_add(int onum)
 		ret = 0;
 		goto out_free_data;
 	}
-	of_node_set_flag(info->np_overlay, OF_DETACHED);
 
 	ret = of_resolve_phandles(info->np_overlay);
 	if (ret) {