From: Sachin Kamat <sachin.kamat@linaro.org>
Date: Wed, 12 Sep 2012 06:30:01 +0000 (+0530)
Subject: tty: serial: Samsung: Fix return value
X-Git-Tag: v3.7-rc1~172^2~34
X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=e740d8f1a0a23a8fea8fbc5a02013c7410283665;p=linux.git

tty: serial: Samsung: Fix return value

Return the value returned by the failing function instead
of -1 (which does not convey the right error information).

Fixes the following smatch warning:
drivers/tty/serial/samsung.c:1687 s3c24xx_serial_modinit() info:
why not propagate 'ret' from uart_register_driver() instead of -1?

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
index bdaa06f3ab69..8eef1141b81d 100644
--- a/drivers/tty/serial/samsung.c
+++ b/drivers/tty/serial/samsung.c
@@ -1684,7 +1684,7 @@ static int __init s3c24xx_serial_modinit(void)
 	ret = uart_register_driver(&s3c24xx_uart_drv);
 	if (ret < 0) {
 		pr_err("Failed to register Samsung UART driver\n");
-		return -1;
+		return ret;
 	}
 
 	return platform_driver_register(&samsung_serial_driver);