From: Simon Tatham <anakin@pobox.com>
Date: Mon, 13 Aug 2001 12:43:29 +0000 (+0000)
Subject: Fix potential segfault in port forwarding code
X-Git-Tag: 0.52~248
X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=f0d968ce498a8e77d6ad656dcf6cb168d772ebd7;p=PuTTY.git

Fix potential segfault in port forwarding code

[originally from svn r1184]
---

diff --git a/portfwd.c b/portfwd.c
index 76531fb3..4d77ae17 100644
--- a/portfwd.c
+++ b/portfwd.c
@@ -248,8 +248,6 @@ void pfd_close(Socket s)
  */
 void pfd_send(Socket s, char *data, int len)
 {
-    struct PFwdPrivate *pr = (struct PFwdPrivate *) sk_get_private_ptr(s);
-
     if (s == NULL)
 	return;
 
@@ -259,11 +257,12 @@ void pfd_send(Socket s, char *data, int len)
 
 void pfd_confirm(Socket s)
 {
-    struct PFwdPrivate *pr = (struct PFwdPrivate *) sk_get_private_ptr(s);
+    struct PFwdPrivate *pr;
 
     if (s == NULL)
 	return;
 
+    pr = (struct PFwdPrivate *) sk_get_private_ptr(s);
     pr->ready = 1;
     sk_set_frozen(s, 0);
     sk_write(s, NULL, 0);