From: Uwe Kleine-König Date: Thu, 7 Aug 2014 21:48:25 +0000 (+0200) Subject: net: ucc_geth: make probe consistently acquire a reference to the phy node X-Git-Tag: v3.17-rc1~33^2~27 X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=f1f02fa4f15bc682814c71fe05c6b76e5f5fba80;p=linux.git net: ucc_geth: make probe consistently acquire a reference to the phy node When the driver attaches to a device that has a phy handle the probe routine returns with a reference to that node. This reference is correctly dropped in the error path and the remove function. In the fixed phy case however no reference is acquired and so the error path might drop a reference the driver isn't holding. Fix that by getting a reference to the MAC. Fixes: 87009814cdbb ("ucc_geth: use the new fixed PHY helpers") Signed-off-by: Uwe Kleine-König Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c index f6b956952269..0c83ef078ddf 100644 --- a/drivers/net/ethernet/freescale/ucc_geth.c +++ b/drivers/net/ethernet/freescale/ucc_geth.c @@ -3794,7 +3794,7 @@ static int ucc_geth_probe(struct platform_device* ofdev) if (err) return err; } - ug_info->phy_node = np; + ug_info->phy_node = of_node_get(np); } /* Find the TBI PHY node. If it's not there, we don't support SGMII */