From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 22 Apr 2016 10:04:14 +0000 (+0300)
Subject: iio: light: apds9960: silence uninitialized variable warning
X-Git-Tag: v4.7-rc1~90^2~349^2~16
X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=f21122593d99c7e051891da1b148c771b7d56e07;p=linux.git

iio: light: apds9960: silence uninitialized variable warning

It causes a static checker warning if we use "buf" on the failure path
so move that inside the if statement.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
---

diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
index 47fcd5ad4ff2..35928fb1b66a 100644
--- a/drivers/iio/light/apds9960.c
+++ b/drivers/iio/light/apds9960.c
@@ -495,9 +495,10 @@ static int apds9960_read_raw(struct iio_dev *indio_dev,
 		case IIO_INTENSITY:
 			ret = regmap_bulk_read(data->regmap, chan->address,
 					       &buf, 2);
-			if (!ret)
+			if (!ret) {
 				ret = IIO_VAL_INT;
-			*val = le16_to_cpu(buf);
+				*val = le16_to_cpu(buf);
+			}
 			break;
 		default:
 			ret = -EINVAL;