From: David S. Miller Date: Mon, 6 Oct 2014 01:15:23 +0000 (-0400) Subject: Merge branch 'spider_net' X-Git-Tag: v3.18-rc1~115^2^2~6 X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=f408c3d956c987844dcb7c6837abfbb0331fb7f6;p=linux.git Merge branch 'spider_net' Antoine Tenart says: ==================== net: spider_net: fix possible bitops errors Dan reported a possible signedness issue on the pxa168_eth driver. While having a look at it, I came across a similar problem in the spider_net driver. Here is one proposal to fix it. The first patch rework the spider_net_set_mac() function by removing the spider_net_get_mac_address() call and using memcpy() to set netdev->dev_addr (which is what's done in lots of Ethernet drivers) and the second one fix the actual signedness issue. If for any reason you really want to keep a call to spider_net_get_mac_address() because the memcpy() is somehow not good enough here, we can also come up with a solution involving a temporary unsigned char variable. I couldn't test these changes, so please do. ==================== Signed-off-by: David S. Miller --- f408c3d956c987844dcb7c6837abfbb0331fb7f6