From: Simon Tatham <anakin@pobox.com>
Date: Mon, 19 Sep 2011 16:38:23 +0000 (+0000)
Subject: We shouldn't fork off a utmp helper subprocess when we aren't setuid,
X-Git-Tag: 0.63~253
X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=f69591412c6d6efe06e32d46ab6f4d9608197d91;hp=f69591412c6d6efe06e32d46ab6f4d9608197d91;p=PuTTY.git

We shouldn't fork off a utmp helper subprocess when we aren't setuid,
because (a) under that circumstance we won't be writing to utmp
anyway, and (b) if we aren't setuid, then we won't have created the
pty at the point we fork, so even if our subprocess _could_ have
written to utmp it wouldn't have done it right!

Spotted by valgrind (triggering on the access beyond the end of the
ttyname string in setup_utmp, clueing me in to it having been empty).

[originally from svn r9309]
---