From: Scott McKay <swm@google.com>
Date: Thu, 29 Mar 2012 17:44:08 +0000 (+0000)
Subject: Commit changes merged from trunk
X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=f773bd418869b23e1f57f0464ee090d02e4197a2;p=cl-protobufs.git

Commit changes merged from trunk

git-svn-id: http://svn.internal.itasoftware.com/svn/ita/branches/qres/swm/borgify-1/qres/lisp/quux/protobufs@536623 f8382938-511b-0410-9cdd-bb47b084005c
---

diff --git a/wire-format.lisp b/wire-format.lisp
index fec6cd2..f355a3c 100644
--- a/wire-format.lisp
+++ b/wire-format.lisp
@@ -150,8 +150,8 @@
          (encode-double val buffer idx))
         ;; A few of our homegrown types
         ((:symbol)
+         ;; Note that this is consy, avoid it if possible
          (let ((val (format nil "~A:~A" (package-name (symbol-package val)) (symbol-name val))))
-           ;; Call 'string' in case we are trying to serialize a symbol name
            (encode-octets (babel:string-to-octets val :encoding :utf-8) buffer idx)))
         ((:date :time :datetime :timestamp)
          (encode-uint64 val buffer idx))))))
@@ -339,6 +339,7 @@
        (decode-double buffer index))
       ;; A few of our homegrown types
       ((:symbol)
+       ;; Note that this is consy, avoid it if possible
        (multiple-value-bind (val idx)
            (decode-octets buffer index)
          (let* ((val   (babel:octets-to-string val :encoding :utf-8))