From: William Breathitt Gray Date: Sun, 22 Nov 2015 16:38:55 +0000 (-0500) Subject: gpio: 104-idio-16: Disable IRQ on device probe X-Git-Tag: v4.5-rc1~78^2~211 X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=fb50cdfeeda868ae2bfe7ec2e0afebff53eca2d5;p=linux.git gpio: 104-idio-16: Disable IRQ on device probe IRQ should be disabled on device probe so that the device IRQ is in a known starting state. If IRQ is not disabled, interrupts may be reported as handled by the IRQ handler, despite no irq_unmask calls made by the user. Signed-off-by: William Breathitt Gray Signed-off-by: Linus Walleij --- diff --git a/drivers/gpio/gpio-104-idio-16.c b/drivers/gpio/gpio-104-idio-16.c index 81b6904bdfe6..efe3ff7d574e 100644 --- a/drivers/gpio/gpio-104-idio-16.c +++ b/drivers/gpio/gpio-104-idio-16.c @@ -242,6 +242,9 @@ static int __init idio_16_probe(struct platform_device *pdev) goto err_gpio_register; } + /* Disable IRQ by default */ + outb(0, base + 2); + err = gpiochip_irqchip_add(&idio16gpio->chip, &idio_16_irqchip, 0, handle_edge_irq, IRQ_TYPE_NONE); if (err) {