Simon Tatham [Sun, 25 Apr 2004 09:04:38 +0000 (09:04 +0000)]
Make mkfiles.pl less tied to PuTTY in particular, by inventing new
directives that allow me to move some of the PuTTY-specific Makefile
fragments into Recipe. Not complete yet, but ought to be enough for
me to at least _try_ using mkfiles.pl in another project.
Jacob Nevins [Sat, 24 Apr 2004 20:05:03 +0000 (20:05 +0000)]
In SSH, we now send terminal speeds to the server when requesting a pty
(we didn't before) - `ssh-termspeed'.
In the process, I've removed the individual controls on the Telnet and
Rlogin panels and replaced them with one on the Connection panel (since they
were backed by the same storage anyway).
The terminal speeds sent in SSH are logged in the Event Log.
Simon Tatham [Wed, 31 Mar 2004 12:50:17 +0000 (12:50 +0000)]
Add `can I put PuTTY on a coverdisk / bundle it / etc' to the FAQ in
case people are incapable of spotting it on the Feedback page. Also
add to both locations Owen's point about first-line support.
Jacob Nevins [Tue, 30 Mar 2004 11:36:51 +0000 (11:36 +0000)]
Miscellaneous tinkering:
- remove a couple of "fixed in 0.52" (or before) type questions
- mention Mac OS X port that someone was working on
- add a missing {Question}
Jacob Nevins [Fri, 26 Mar 2004 15:18:42 +0000 (15:18 +0000)]
More experimental hackery for `win-dead-keys'. Works for me as well as it did
in the one case I can test, but I suspect this isn't the whole story. Bletch.
Jacob Nevins [Thu, 25 Mar 2004 11:33:17 +0000 (11:33 +0000)]
tweak text about mouse reporting and copy and paste to indicate that shift's
only necessary for mouse-based actions (since we seem to be growing more
copy-and-paste options)
Simon Tatham [Wed, 24 Mar 2004 19:36:04 +0000 (19:36 +0000)]
Now that Halibut is capable of generating man pages better than I
can do it by hand, I've converted the man page set from Unix PuTTY
into Halibut format, and enhanced the Makefile so it will build
them. At some future point this will also allow me to include the
man pages as an appendix in the main manual (once I _have_ a main
manual for Unix PuTTY).
Jacob Nevins [Wed, 24 Mar 2004 14:53:51 +0000 (14:53 +0000)]
Fix from Thomas Henlich for bug in dead key support. I've reproduced the
problem and verified the fix on Win2K with the US-International keyboard layout.
(Closes: `win-dead-keys')
<20040323143836.GA40414@rcs.urz.tu-dresden.de>
Owen Dunn [Wed, 10 Mar 2004 17:11:12 +0000 (17:11 +0000)]
Make `Copy all to Clipboard' copy all non-empty lines from the
scrollback and the terminal to the clipboard, rather than just the
content before the cursor. Should fix copyall-to-cursor.
Simon Tatham [Thu, 12 Feb 2004 19:45:45 +0000 (19:45 +0000)]
Modifications to the release procedure as a result of actually
trying to _follow_ it for the first time :-) And also due to the
fact that it now needs to mention the Unix source tarball as well.
Simon Tatham [Tue, 10 Feb 2004 19:07:45 +0000 (19:07 +0000)]
Jacob reports a segfault when using HTTP proxying under Minefield.
It appears that this is because Visual C's sscanf works by first
calling strlen to get the length of the string, so that its internal
read-character routine can be sure of never overrunning the buffer.
Quite why the internal read-char routine can't detect \0 _itself_
rather than having to have it found for it in advance I have no
idea. Sigh.
Simon Tatham [Sat, 7 Feb 2004 18:10:54 +0000 (18:10 +0000)]
Added a wrinkle to the version.c build in the Unix makefile, which
will validate an md5sums manifest and if all md5sums match will use
a version number provided in a file. This should allow me to produce
a Unix release source archive with the property that when unpacked
and built it will produce binaries advertising themselves as
`Release X.YZ', but as soon as the user starts fiddling with the
sources it will revert to `Unidentified build' (though of course the
user can still _explicitly_ ask for a release tag, and in fact this
will override the default if any default is specified).
Simon Tatham [Sat, 7 Feb 2004 10:02:20 +0000 (10:02 +0000)]
Charles Wilcox reported a signature validation bug with 2500-bit RSA
keys. This _appears_ to be due to me computing the byte count of the
key by dividing the bit count by 8 and rounding _down_ rather than
up. Therefore, I can't see how this code could ever have worked on
any SSH2 RSA key whose length was not a multiple of 8 bits; and
therefore I'm staggered that we haven't noticed it before! OpenSSH's
keygen appears to be scrupulous about ensuring the returned key
length is exactly what you asked for rather than one bit less, but
even so I'm astonished that _all_ keygen implementations for servers
we've ever interoperated with have avoided tripping this bug...
Jacob Nevins [Tue, 3 Feb 2004 14:47:43 +0000 (14:47 +0000)]
Patch from Theo Markettos: apparently "BSD-derived IP stacks fall over when
trying to bind to the localhost interface with a sockaddr_in which has non-zero
sin_zero fields." Zero sockaddr_in (and sockaddr_in6) before any use.
Simon Tatham [Thu, 22 Jan 2004 19:15:32 +0000 (19:15 +0000)]
Added a command-line key generation tool. Currently builds and runs
on Linux, but the (very few) platform-specific bits are already
abstracted out of the main code, so it should port to other
platforms with a minimum of fuss.
Simon Tatham [Wed, 21 Jan 2004 21:11:03 +0000 (21:11 +0000)]
Bah! Nicolas Barry correctly points out that my async agent code
simply doesn't work - if multiple concurrent agent requests are
attempted, some of them will fail for no apparent reason. I assume
concurrent SendMessage() calls don't work in the Windows API, or
some such. So I'm commenting out the async code for the moment
(there wasn't a Windows Pageant that made helpful use of it anyway
yet) and returning to the drawing board.
Simon Tatham [Wed, 21 Jan 2004 20:59:20 +0000 (20:59 +0000)]
Kaisuke Nakajima points out that it's unnecessary to translate
negative font sizes (meaning pixels) into positive ones (points) in
winstore.c, since it gets done anyway at the point of font creation;
and removing the code in winstore.c means that the precise font
entered by the user is saved in the config, rather than being
rounded.
Simon Tatham [Wed, 21 Jan 2004 19:56:08 +0000 (19:56 +0000)]
Darryl L. Miles's patch to support an optional port number argument
on the PSFTP `open' command; it was arguably a bug that this command
couldn't do such an obvious thing that could be done from the main
command line. Also had to fix a NULL-dereference in do_sftp_cleanup
in the process.
Simon Tatham [Tue, 20 Jan 2004 20:35:27 +0000 (20:35 +0000)]
Alexey Savelyev's mkfiles.pl patch to support lcc-win32. This has
caused a small amount of extra inconvenience at the tops of .rc
files, but it's been positive overall since lcc has managed to point
out some pedantic errors (typically static/extern mismatches between
function prototypes and definitions) which everything else missed.
Simon Tatham [Tue, 20 Jan 2004 19:41:43 +0000 (19:41 +0000)]
Josh Hill's patch for full-screen mode on a multi-monitor system:
clicks in the top left of the window should not be detected by
comparing the coordinates with (0,0) since this won't work on
secondary monitors.
Simon Tatham [Tue, 20 Jan 2004 19:30:41 +0000 (19:30 +0000)]
Mark Wutzke points out that the comment in sk_proxy_set_frozen()
states that plug_receive() may recurse back into
sk_proxy_set_frozen() again. Therefore, bufchain_consume() should
have been called _before_ calling plug_receive(), to prevent an
infinite loop overflowing the stack. I can't immediately figure out
under what circumstances this might happen, but it seems an
obviously sensible precaution.
Jacob Nevins [Tue, 20 Jan 2004 12:46:36 +0000 (12:46 +0000)]
`portfwd-loopback-choice' was not consistently documented.
- update usage info in tools
- ack, plink is over 24 lines now
- update man pages for Unix version
- Doc changes:
- move long description from (GUI) "config" to "using"
- sorry if complete specification isn't what this section is meant for,
but if you only read "using" it was hard to find.
- ensure enough references to this made in other sections (GUI,
command-line)
- update instance of plink usage info
Simon Tatham [Sun, 18 Jan 2004 09:14:41 +0000 (09:14 +0000)]
Memory management fixes. Fixed a segfault in SSH1 compression
cleanup noticed by Gerhard Wiesinger, and also fixed some memory
leaks spotted by valgrind while debugging same.
Simon Tatham [Sat, 17 Jan 2004 13:48:40 +0000 (13:48 +0000)]
Joe Yates's patch to make mkfiles.pl generate Visual Studio project
files as well as an nmake makefile. Needed line-end tweakery in
order to be able to generate usable project files when run on Unix,
but other than that appears fine. Ooh!
Simon Tatham [Sat, 17 Jan 2004 13:24:59 +0000 (13:24 +0000)]
So _that's_ why mkfiles.pl was running so slowly on my Windows box!
&findfile() now caches its results. At least one full order of
magnitude speedup when running on an SMB-mounted volume. Phew.
Simon Tatham [Sat, 17 Jan 2004 13:00:18 +0000 (13:00 +0000)]
Idiot me! store_host_key() was blindly _appending_ new host keys to
the end of the host key file. This is perfectly all right if a host
key never changes, but it's completely useless if you need to
replace an existing entry. This version should do better.
Simon Tatham [Thu, 1 Jan 2004 16:42:48 +0000 (16:42 +0000)]
Joe Yates's memory leak patch was overenthusiastically freeing
things; it called freebn on the DH gex values even if DH gex had not
taken place. Bug was trivially reproducible as a NULL-dereference
segfault by making any SSH2 connection with DH gex disabled. Should
now be fixed.
Simon Tatham [Tue, 16 Dec 2003 18:28:43 +0000 (18:28 +0000)]
Andy Hood points out that `#ifdef MONITOR_DEFAULTTONEAREST' would
benefit from _also_ being conditional on NO_MULTIMON not being
defined, to prevent the possibility of only half the multimon code
being included.