]> asedeno.scripts.mit.edu Git - PuTTY.git/log
PuTTY.git
21 years agoAdd constants to mac_res.r to set the binary version number.
Ben Harris [Tue, 14 Jan 2003 19:29:18 +0000 (19:29 +0000)]
Add constants to mac_res.r to set the binary version number.
Mention this in CHECKLST as a location where the version number has to be set.

[originally from svn r2598]

21 years agoconst fallout.
Ben Harris [Tue, 14 Jan 2003 19:09:24 +0000 (19:09 +0000)]
const fallout.

[originally from svn r2597]

21 years agoRemove debugging printfs from mac_workoutfontscale().
Ben Harris [Tue, 14 Jan 2003 18:44:34 +0000 (18:44 +0000)]
Remove debugging printfs from mac_workoutfontscale().

[originally from svn r2595]

21 years agoMiscellaneous fixes to finish up `remove-statics'. rlogin.c had a
Simon Tatham [Tue, 14 Jan 2003 18:43:45 +0000 (18:43 +0000)]
Miscellaneous fixes to finish up `remove-statics'. rlogin.c had a
holdout static I hadn't noticed; unicode.c had one too; and a large
number of statics that were perfectly OK due to being constants have
been made `const', with assorted `const' repercussions all over the
place. I now declare `remove-statics' to be fixed.

[originally from svn r2594]

21 years agoAdd double width/height support. This passes all the relevant parts of
Ben Harris [Tue, 14 Jan 2003 18:43:26 +0000 (18:43 +0000)]
Add double width/height support.  This passes all the relevant parts of
vttest apart from the "mad programmer" screen, which I think is a linedraw
problem.
This also intorduces proper clipping of the drawn text for good measure.

[originally from svn r2593]

21 years agoDeglobalise the Unicode module. Despite all my grand plans, I've
Simon Tatham [Tue, 14 Jan 2003 18:28:23 +0000 (18:28 +0000)]
Deglobalise the Unicode module. Despite all my grand plans, I've
just done this the very simple way - bundle all the globals into a
data structure and pass pointers around. One particularly ugly wart
is that wc_to_mb now takes a pointer to this structure as an
argument (optional, may be NULL, and unused in any Unicode layer
that's even marginally less of a mess than the Windows one). I do
need to do this properly at some point, but for now this should just
about be adequate. As usual, the Mac port has not been updated.

[originally from svn r2592]

21 years agorequest_resize() needs to call term_size() to tell the terminal emulator
Ben Harris [Tue, 14 Jan 2003 15:24:51 +0000 (15:24 +0000)]
request_resize() needs to call term_size() to tell the terminal emulator
that its resize request has been approved.

[originally from svn r2591]

21 years agoIt's impossible to write a checklist from scratch without leaving
Simon Tatham [Tue, 14 Jan 2003 15:01:18 +0000 (15:01 +0000)]
It's impossible to write a checklist from scratch without leaving
one or two things out of the first version.

[originally from svn r2590]

21 years agoAfter the New Year copyright-dates fiasco, I think it's about time
Simon Tatham [Tue, 14 Jan 2003 14:19:35 +0000 (14:19 +0000)]
After the New Year copyright-dates fiasco, I think it's about time
we had one or two official checklists. This file lists the locations
of _all_ the copies of the licence and the copyright dates, all the
files in CVS which need to know the current version number, and also
lays out the release procedure since I always find it terribly
fiddly to do it all in the right order.
PLEASE KEEP THESE LISTS UP TO DATE, people! Anyone adds a new copy
of the licence or the copyright notice, shout about it in here.
Likewise any file that needs to know the current release number and
can't get away with referencing LATEST.VER.

[originally from svn r2589]

21 years agoCtrl-PgUp and Ctrl-PgDn now scroll by one line on Unix and Windows
Owen Dunn [Tue, 14 Jan 2003 11:24:26 +0000 (11:24 +0000)]
Ctrl-PgUp and Ctrl-PgDn now scroll by one line on Unix and Windows

[originally from svn r2582]

21 years agoOops - put the right `void *' in back->reconfig.
Simon Tatham [Mon, 13 Jan 2003 18:03:55 +0000 (18:03 +0000)]
Oops - put the right `void *' in back->reconfig.

[originally from svn r2579]

21 years agoMake ^/ do the same as ^_ (wish control-slash)
Owen Dunn [Mon, 13 Jan 2003 15:06:56 +0000 (15:06 +0000)]
Make ^/ do the same as ^_ (wish control-slash)

[originally from svn r2576]

21 years agoSet the window title to the canonical host name when we connect.
Ben Harris [Sun, 12 Jan 2003 16:25:58 +0000 (16:25 +0000)]
Set the window title to the canonical host name when we connect.

[originally from svn r2574]

21 years agoConsequences of Simon's recent deglobalisation changes.
Ben Harris [Sun, 12 Jan 2003 16:11:27 +0000 (16:11 +0000)]
Consequences of Simon's recent deglobalisation changes.

[originally from svn r2573]

21 years agoWhen receiving data, only pass up to the backend as much as we received.
Ben Harris [Sun, 12 Jan 2003 15:46:33 +0000 (15:46 +0000)]
When receiving data, only pass up to the backend as much as we received.

[originally from svn r2572]

21 years agoAhem. Doing loads of stuff to inst->cfg would probably be best done
Simon Tatham [Sun, 12 Jan 2003 15:45:29 +0000 (15:45 +0000)]
Ahem. Doing loads of stuff to inst->cfg would probably be best done
_after_ allocating inst. Oops.

[originally from svn r2571]

21 years agoMake this compile again.
Ben Harris [Sun, 12 Jan 2003 15:42:24 +0000 (15:42 +0000)]
Make this compile again.

[originally from svn r2570]

21 years agoAhem. Global replace of `cfg' with `inst->cfg' is all very well, but
Simon Tatham [Sun, 12 Jan 2003 15:36:05 +0000 (15:36 +0000)]
Ahem. Global replace of `cfg' with `inst->cfg' is all very well, but
let's try to make sure it doesn't happen inside any strings! The
-cfg option for cursor foreground colour nearly had a nasty accident
there.

[originally from svn r2569]

21 years agoHaving laid all the groundwork, we can now remove the global `cfg'
Simon Tatham [Sun, 12 Jan 2003 15:32:31 +0000 (15:32 +0000)]
Having laid all the groundwork, we can now remove the global `cfg'
completely from putty.h. It's now static in each of the command-line
front ends, shared only between window.c and windlg.c in PuTTY
proper (I've tested this by doing #define cfg cfgsillyname in those
two files only, and it still links so nobody else is using that
symbol!), and part of the `inst' structure in pterm. I think that
only leaves the Unicode module as the last stubborn holdout in the
anti-global-variables campaign.

[originally from svn r2568]

21 years agoproxy.c now no longer refers to `cfg'. Instead, each of the three
Simon Tatham [Sun, 12 Jan 2003 15:26:10 +0000 (15:26 +0000)]
proxy.c now no longer refers to `cfg'. Instead, each of the three
proxy-indirection network functions (name_lookup, new_connection,
new_listener) takes a `const Config *' as an argument, and extracts
enough information from it before returning to handle that
particular network operation in accordance with the proxy settings
it specifies. This involved {win,ux}net.c due to a `const'
repercussion.

[originally from svn r2567]

21 years agoThe logging module now contains a local copy of cfg too.
Simon Tatham [Sun, 12 Jan 2003 15:10:27 +0000 (15:10 +0000)]
The logging module now contains a local copy of cfg too.

[originally from svn r2566]

21 years agoThe Unicode module no longer depends on `cfg', since it gets the
Simon Tatham [Sun, 12 Jan 2003 14:59:54 +0000 (14:59 +0000)]
The Unicode module no longer depends on `cfg', since it gets the
relevant bits of it passed in to init_ucs(). (Actually I pass in all
of it in the Windows version, since it's a bit hairy in there.)

[originally from svn r2565]

21 years agoThere's no real need for portfwd.c to reference `cfg' directly, when
Simon Tatham [Sun, 12 Jan 2003 14:56:19 +0000 (14:56 +0000)]
There's no real need for portfwd.c to reference `cfg' directly, when
it only needs one item from it and that can easily be passed in from
the call site in ssh.c.

[originally from svn r2564]

21 years agoprinter_start_job shouldn't need to refer to cfg.printer, since it's
Simon Tatham [Sun, 12 Jan 2003 14:50:34 +0000 (14:50 +0000)]
printer_start_job shouldn't need to refer to cfg.printer, since it's
getting the printer name passed in anyway! Oops.

[originally from svn r2563]

21 years agoJust like under Windows, cleanup_exit() shouldn't need to check
Simon Tatham [Sun, 12 Jan 2003 14:49:44 +0000 (14:49 +0000)]
Just like under Windows, cleanup_exit() shouldn't need to check
before calling random_save_seed().

[originally from svn r2562]

21 years agoThe back ends now contain their own copies of the Config structure,
Simon Tatham [Sun, 12 Jan 2003 14:48:29 +0000 (14:48 +0000)]
The back ends now contain their own copies of the Config structure,
and have a function to pass in a new one. (Well, actually several
back ends don't actually bother to do this because they need nothing
out of Config after the initial setup phase, but they could if they
wanted to.)

[originally from svn r2561]

21 years agoCall ot_poll as appropriate.
Ben Harris [Sun, 12 Jan 2003 14:45:33 +0000 (14:45 +0000)]
Call ot_poll as appropriate.
Also use cleanup_exit() in preference to exit() so that MacTCP gets shut down
even on unclean exits.

[originally from svn r2560]

21 years agoDon't fatalbox() unconditionally when opening a connection, since that makes
Ben Harris [Sun, 12 Jan 2003 14:44:12 +0000 (14:44 +0000)]
Don't fatalbox() unconditionally when opening a connection, since that makes
it a little difficult to do anything.

[originally from svn r2559]

21 years agoForgot to match the cmdline changes in the Unix port.
Simon Tatham [Sun, 12 Jan 2003 14:37:26 +0000 (14:37 +0000)]
Forgot to match the cmdline changes in the Unix port.

[originally from svn r2558]

21 years agoterm->cfg is now a full copy of the Config structure, not a pointer;
Simon Tatham [Sun, 12 Jan 2003 14:30:02 +0000 (14:30 +0000)]
term->cfg is now a full copy of the Config structure, not a pointer;
and term_reconfig() now passes in a new structure which is copied
over the top. This means that the old and new structures can be
compared, and the _current_ as well as default states of auto wrap
mode, DEC origin mode, BCE, blinking text and character classes can
be conveniently reconfigured in mid-session without requiring a
terminal reset.

[originally from svn r2557]

21 years agoCOmpiling _before_ committing is usually a good idea.
Ben Harris [Sun, 12 Jan 2003 14:23:00 +0000 (14:23 +0000)]
COmpiling _before_ committing is usually a good idea.

[originally from svn r2556]

21 years agoThe command-line routines now take a pointer to `cfg' as an
Simon Tatham [Sun, 12 Jan 2003 14:17:03 +0000 (14:17 +0000)]
The command-line routines now take a pointer to `cfg' as an
argument, so they don't depend on it being a global any more.

[originally from svn r2555]

21 years agoSupport for XDM-AUTHORIZATION-1 at the SSH server end, making use of
Simon Tatham [Sun, 12 Jan 2003 14:11:38 +0000 (14:11 +0000)]
Support for XDM-AUTHORIZATION-1 at the SSH server end, making use of
the remote IP/port data provided by the server for forwarded
connections. Disabled by default, since it's incompatible with SSH2,
probably incompatible with some X clients, and tickles a bug in
at least one version of OpenSSH.

[originally from svn r2554]

21 years agoCorrect code to insert into a doubly-linked list.
Ben Harris [Sun, 12 Jan 2003 13:50:04 +0000 (13:50 +0000)]
Correct code to insert into a doubly-linked list.

[originally from svn r2553]

21 years agoEach platform's implementation of askappend() is no longer required
Simon Tatham [Sun, 12 Jan 2003 13:44:35 +0000 (13:44 +0000)]
Each platform's implementation of askappend() is no longer required
to consult cfg.logxfovr, because it gets done once in logging.c.
askappend() is now called only when a question _really_ needs to be
asked of the user. Also in this checkin, cleanup_exit() in console.c
no longer consults cfg.protocol to decide whether to save the random
seed, because random_save_seed() can make that decision for itself
and do it better.

[originally from svn r2552]

21 years agoCute though DNSAddresses are, they're a poor match for the model the
Ben Harris [Sun, 12 Jan 2003 13:06:59 +0000 (13:06 +0000)]
Cute though DNSAddresses are, they're a poor match for the model the
rest of PuTTY has of DNS resolution, so I've replaced them with something
more conventional.  Sorry.

The new code has the advantage of working, of course.

[originally from svn r2551]

21 years agoUse memset() rather than OTMemzero(), and hence remove the need to weak link
Ben Harris [Sun, 12 Jan 2003 01:37:24 +0000 (01:37 +0000)]
Use memset() rather than OTMemzero(), and hence remove the need to weak link
against OTUtilityLib.

[originally from svn r2550]

21 years agoRemove code for splatting test data into new terminals, since we can do
Ben Harris [Sun, 12 Jan 2003 01:25:34 +0000 (01:25 +0000)]
Remove code for splatting test data into new terminals, since we can do
that over real network connections now.

[originally from svn r2549]

21 years agoChange error handling to store the error number rather than the string,
Ben Harris [Sun, 12 Jan 2003 01:24:03 +0000 (01:24 +0000)]
Change error handling to store the error number rather than the string,
and to convert to a string only on demand.  This makes it possible to have
the string contain the error number if we don't recognise it.

[originally from svn r2548]

21 years agoInitial import of Owen's OpenTransport interface. It doesn't work yet, but
Ben Harris [Sat, 11 Jan 2003 23:33:57 +0000 (23:33 +0000)]
Initial import of Owen's OpenTransport interface.  It doesn't work yet, but
it does compile and link.

[originally from svn r2547]

21 years agoAdd an indirection layer between mtcpnet.c and the rest of PuTTY so that
Ben Harris [Sat, 11 Jan 2003 19:43:59 +0000 (19:43 +0000)]
Add an indirection layer between mtcpnet.c and the rest of PuTTY so that
we can have runtime switching between MacTCP and OpenTransport, and so
that we can cope if there's no TCP/IP stack available at all (albeit with
very little functionality at present).

[originally from svn r2546]

21 years agoCalling plug_closing() is highly likely to result in a call to sk_close(),
Ben Harris [Sat, 11 Jan 2003 17:36:24 +0000 (17:36 +0000)]
Calling plug_closing() is highly likely to result in a call to sk_close(),
so arrange that mactcp_poll() can cope with that and not access freed memory
when it happens.

[originally from svn r2545]

21 years agoWhen polling MacTCP connections, check the connection state and if the far
Ben Harris [Sat, 11 Jan 2003 17:31:59 +0000 (17:31 +0000)]
When polling MacTCP connections, check the connection state and if the far
end has sent a FIN pass that up to the plug.
TODO: handle less graceful connection closures.

[originally from svn r2544]

21 years agoMove the prototype for platform_get_x11_auth() from x11fwd.c to ssh.h so that
Ben Harris [Sat, 11 Jan 2003 14:20:00 +0000 (14:20 +0000)]
Move the prototype for platform_get_x11_auth() from x11fwd.c to ssh.h so that
it can be checked against the implementation.

[originally from svn r2542]

21 years agoAdd a cast for a char * vs unsigned char * conflict.
Ben Harris [Sat, 11 Jan 2003 14:08:46 +0000 (14:08 +0000)]
Add a cast for a char * vs unsigned char * conflict.

[originally from svn r2541]

21 years agoconst fallout from Simon's X forwarding changes.
Ben Harris [Sat, 11 Jan 2003 14:08:07 +0000 (14:08 +0000)]
const fallout from Simon's X forwarding changes.

[originally from svn r2540]

21 years agoYet _another_ `received data for nonexistent channel' bug. This time
Simon Tatham [Sat, 11 Jan 2003 10:05:29 +0000 (10:05 +0000)]
Yet _another_ `received data for nonexistent channel' bug. This time
it was because we received WINDOW_ADJUST on a channel we'd already
sent CLOSE on, and reflexively attempted to continue sending the
buffered data in response. Should now be fixed.

[originally from svn r2539]

21 years agoHack around an oddity in X display names and xauth.
Simon Tatham [Sat, 11 Jan 2003 09:46:50 +0000 (09:46 +0000)]
Hack around an oddity in X display names and xauth.

[originally from svn r2538]

21 years agoSupport XDM-AUTHORIZATION-1 for connecting to local X servers. If
Simon Tatham [Sat, 11 Jan 2003 09:31:54 +0000 (09:31 +0000)]
Support XDM-AUTHORIZATION-1 for connecting to local X servers. If
we're going to be a security program, we can at least make a token
effort to use the most secure local X auth available! And I'm still
half-tempted to see if I can support it for remote X servers too...

[originally from svn r2537]

21 years agoIntroduce framework for authenticating with the local X server.
Simon Tatham [Fri, 10 Jan 2003 18:33:35 +0000 (18:33 +0000)]
Introduce framework for authenticating with the local X server.
Windows and Mac backends have acquired auth-finding functions which
do nothing; Unix backend has acquired one which actually works, so
Plink can now do X forwarding believably.
(This checkin stretches into some unlikely parts of the code because
there have been one or two knock-on effects involving `const'. Bah.)

[originally from svn r2536]

21 years agoAsk for a meaningful subject line on messages.
Ben Harris [Fri, 10 Jan 2003 15:23:01 +0000 (15:23 +0000)]
Ask for a meaningful subject line on messages.

[originally from svn r2532]

21 years agoImplement get_window_title().
Ben Harris [Thu, 9 Jan 2003 23:29:22 +0000 (23:29 +0000)]
Implement get_window_title().

[originally from svn r2525]

21 years agoForcibly close any TCP connections that are still open when PuTTY exits.
Ben Harris [Thu, 9 Jan 2003 23:04:34 +0000 (23:04 +0000)]
Forcibly close any TCP connections that are still open when PuTTY exits.
This saves leaving them lying around to crash the machine later.

[originally from svn r2524]

21 years agoUse c2pstrcpy() rather than silly sprintf() tricks.
Ben Harris [Thu, 9 Jan 2003 22:51:41 +0000 (22:51 +0000)]
Use c2pstrcpy() rather than silly sprintf() tricks.

[originally from svn r2523]

21 years agoc2pstr() is deprecated. Use c2pstrcpy() instead.
Ben Harris [Thu, 9 Jan 2003 22:45:48 +0000 (22:45 +0000)]
c2pstr() is deprecated.  Use c2pstrcpy() instead.

[originally from svn r2522]

21 years agoTake advantage of having control over the default font to do the job properly:
Ben Harris [Thu, 9 Jan 2003 22:39:47 +0000 (22:39 +0000)]
Take advantage of having control over the default font to do the job properly:
ask the system script what it's preferred monospaced font is, and use that
if possible.  Failing, that, try the Roman script system, and if that fails,
fall back to Monaco 9.

[originally from svn r2521]

21 years agoSet PuTTY's canBackground flag so that it receives CPU time (to process
Ben Harris [Thu, 9 Jan 2003 19:27:29 +0000 (19:27 +0000)]
Set PuTTY's canBackground flag so that it receives CPU time (to process
incoming data) while in the background.

[originally from svn r2520]

21 years agoInstall a notification procedure (ASR) on each TCP connection that wakes
Ben Harris [Thu, 9 Jan 2003 19:26:39 +0000 (19:26 +0000)]
Install a notification procedure (ASR) on each TCP connection that wakes
PuTTY up when something happens.  This should allow it to receive data without
having to poll for it continuously.

[originally from svn r2519]

21 years agoRemove the diagnostic added in rev 1.42 [r2288]; apparently it's all
Simon Tatham [Thu, 9 Jan 2003 19:26:12 +0000 (19:26 +0000)]
Remove the diagnostic added in rev 1.42 [r2288]; apparently it's all
true and WinSock _does_ occasionally send us netevent messages with
no socket for no reason. Ignore them when they appear.

[originally from svn r2518]
[r2288 == 3bb2e4568c15f5cd76544772ec20f337b8ffb8d5]

21 years agoSwitching from -opt space to -opt time on 68K Macs only loses us about 2K
Ben Harris [Thu, 9 Jan 2003 19:24:02 +0000 (19:24 +0000)]
Switching from -opt space to -opt time on 68K Macs only loses us about 2K
of disc space, and we need all the speed we can get, so do that.

[originally from svn r2517]

21 years agoUnix plink now catches SIGWINCH and propagates local terminal
Simon Tatham [Thu, 9 Jan 2003 18:28:01 +0000 (18:28 +0000)]
Unix plink now catches SIGWINCH and propagates local terminal
resizes to the remote end.

[originally from svn r2515]

21 years agoSupport asynchronous connect() in Unix networking. Now a port
Simon Tatham [Thu, 9 Jan 2003 18:14:24 +0000 (18:14 +0000)]
Support asynchronous connect() in Unix networking. Now a port
forwarding to a nonexistent host shouldn't hold up the rest of the
program.

[originally from svn r2514]

21 years agoI'm sick of all those #ifdefs in settings.c, and in any case plink
Simon Tatham [Thu, 9 Jan 2003 18:06:29 +0000 (18:06 +0000)]
I'm sick of all those #ifdefs in settings.c, and in any case plink
and pterm need at least one default setting to be _different_ (pterm
needs the default term type to be `xterm', while plink needs it to
be taken from $TERM). So here's a completely new alternative
mechanism for platform- and app-specific default settings. Ben will
probably want to check the integrity of the Mac port, since I've
fiddled with it without testing that it still compiles.

[originally from svn r2513]

21 years agoYikes! Forgot to zero the password after SSH2 PW authentication.
Simon Tatham [Thu, 9 Jan 2003 17:33:49 +0000 (17:33 +0000)]
Yikes! Forgot to zero the password after SSH2 PW authentication.

[originally from svn r2512]

21 years agoAdd PuTTYtel binaries.
Ben Harris [Wed, 8 Jan 2003 23:58:50 +0000 (23:58 +0000)]
Add PuTTYtel binaries.

[originally from svn r2503]

21 years agoRather useless entropy-collection functions for Mac OS. These need work.
Ben Harris [Wed, 8 Jan 2003 23:56:48 +0000 (23:56 +0000)]
Rather useless entropy-collection functions for Mac OS.  These need work.

[originally from svn r2502]

21 years agoThe CFM-68K build isn't working at the moment (we blow past its global data
Ben Harris [Wed, 8 Jan 2003 22:48:57 +0000 (22:48 +0000)]
The CFM-68K build isn't working at the moment (we blow past its global data
limit what with libcharset and the crypto stuff), so don't include it in
"all".

[originally from svn r2501]

21 years agoFairly major hackery to get SSH going on the Mac. Half the support
Ben Harris [Wed, 8 Jan 2003 22:46:12 +0000 (22:46 +0000)]
Fairly major hackery to get SSH going on the Mac.  Half the support
functions are only dummy stubs, but it's still minimally usable.  At
least, as long as you don't want to do anything complex like logging out.

[originally from svn r2500]

21 years agoWe just got mailed a Dr Watson log which suggests I failed to
Simon Tatham [Wed, 8 Jan 2003 09:15:56 +0000 (09:15 +0000)]
We just got mailed a Dr Watson log which suggests I failed to
initialise term->paste_len during initialisation, and indeed looking
at the code confirms this. I'm puzzled as to why valgrind didn't
spot this in pterm, though, since it's all in cross-platform code!

[originally from svn r2494]

21 years agoUse '\012' as the end of the SSH banner line, not '\n'.
Ben Harris [Tue, 7 Jan 2003 23:05:12 +0000 (23:05 +0000)]
Use '\012' as the end of the SSH banner line, not '\n'.
Mac compilers default to making '\n' == '\015'.

[originally from svn r2493]

21 years agoInitialise the "protocol" field of a new ssh_tag to NULL so Bad Things don't
Ben Harris [Tue, 7 Jan 2003 22:45:12 +0000 (22:45 +0000)]
Initialise the "protocol" field of a new ssh_tag to NULL so Bad Things don't
happen if we try to type things before the SSH banner has been received.

[originally from svn r2492]

21 years agoMove the various big tables to the start of the file to save mucking about
Ben Harris [Tue, 7 Jan 2003 20:47:53 +0000 (20:47 +0000)]
Move the various big tables to the start of the file to save mucking about
with ifdefs for specific compilers.

[originally from svn r2491]

21 years agoAhem. Now pterm actually uses wc_to_mb in a situation where it needs
Simon Tatham [Tue, 7 Jan 2003 13:09:56 +0000 (13:09 +0000)]
Ahem. Now pterm actually uses wc_to_mb in a situation where it needs
to pass in a default character, it would help if wc_to_mb actually
_honoured_ the default-character parameter.

[originally from svn r2490]

21 years agoIt looks like Visual C (or whatever the Windows snapshots are built with)
Ben Harris [Mon, 6 Jan 2003 21:46:56 +0000 (21:46 +0000)]
It looks like Visual C (or whatever the Windows snapshots are built with)
objects to incomplete static array declarations, which I introduced to work
around a bug in SC/MrC.  Use #ifdefs to decide whether to enable the workaround
or not.

[originally from svn r2488]

21 years agoOne usually includes .h files, not .c files. That explains why it was
Ben Harris [Sun, 5 Jan 2003 23:48:10 +0000 (23:48 +0000)]
One usually includes .h files, not .c files.  That explains why it was
taking so long to compile!

[originally from svn r2487]

21 years agoInclude putty.h to get prototypes for exported functions.
Ben Harris [Sun, 5 Jan 2003 23:38:11 +0000 (23:38 +0000)]
Include putty.h to get prototypes for exported functions.

[originally from svn r2486]

21 years agozlib_disable_compression() and zlib_huflookup() are unused outside this file.
Ben Harris [Sun, 5 Jan 2003 23:36:53 +0000 (23:36 +0000)]
zlib_disable_compression() and zlib_huflookup() are unused outside this file.
Make them static.

[originally from svn r2485]

21 years agoSHA512_Core_Init() and SHA512_Block() are unused outside this file. Make
Ben Harris [Sun, 5 Jan 2003 23:34:00 +0000 (23:34 +0000)]
SHA512_Core_Init() and SHA512_Block() are unused outside this file.  Make
them static.

[originally from svn r2484]

21 years agorsa2_sign() is unused outside this file. Make it static.
Ben Harris [Sun, 5 Jan 2003 23:32:19 +0000 (23:32 +0000)]
rsa2_sign() is unused outside this file.  Make it static.

[originally from svn r2483]

21 years agorandom_stir() is unused outside this file. Make it static.
Ben Harris [Sun, 5 Jan 2003 23:30:48 +0000 (23:30 +0000)]
random_stir() is unused outside this file.  Make it static.
Include putty.h to get prototypes for random_init() and random_get_savedata().

[originally from svn r2482]

21 years agoMove prototypes for base64_decode_atom(), base64_lines(), and base64_encode()
Ben Harris [Sun, 5 Jan 2003 23:28:02 +0000 (23:28 +0000)]
Move prototypes for base64_decode_atom(), base64_lines(), and base64_encode()
from import.c to ssh.h, so that the implementation can see them.  This
necessitates ssh.h's including <stdio.h>.
Also remove a spare prototype for base64_encode_atom() from import.c.

[originally from svn r2481]

21 years agodss_sign() is unused outside this file. Make it static.
Ben Harris [Sun, 5 Jan 2003 23:14:04 +0000 (23:14 +0000)]
dss_sign() is unused outside this file.  Make it static.

[originally from svn r2480]

21 years agodes_key_setup(), des_encipher(), and des_decipher() are unreferenced outside
Ben Harris [Sun, 5 Jan 2003 23:12:58 +0000 (23:12 +0000)]
des_key_setup(), des_encipher(), and des_decipher() are unreferenced outside
this file.  Make them static.

[originally from svn r2479]

21 years agoInclude ssh.h for the crc32() and crc32_update() prototypes.
Ben Harris [Sun, 5 Jan 2003 23:09:53 +0000 (23:09 +0000)]
Include ssh.h for the crc32() and crc32_update() prototypes.

[originally from svn r2478]

21 years agobigdivmod() is unreferenced outside this file. Make it static.
Ben Harris [Sun, 5 Jan 2003 23:05:49 +0000 (23:05 +0000)]
bigdivmod() is unreferenced outside this file.  Make it static.
diagbn() is unreferenced.  #if it out.

[originally from svn r2477]

21 years agoaes_setup() is unused outside this file. Make it static.
Ben Harris [Sun, 5 Jan 2003 23:03:02 +0000 (23:03 +0000)]
aes_setup() is unused outside this file.  Make it static.

[originally from svn r2476]

21 years agoMake ssh1_pkt_type(), ssh2_pkt_type, logeventf(), setup_userpass_input(),
Ben Harris [Sun, 5 Jan 2003 23:01:43 +0000 (23:01 +0000)]
Make ssh1_pkt_type(), ssh2_pkt_type, logeventf(), setup_userpass_input(),
process_userpass_input(), and ssh_unthrottle() static, since they're not
referenced outside this file.

[originally from svn r2475]

21 years agoMove x11fwd and portfwd prototypes from ssh.c into ssh.h so they can be seen
Ben Harris [Sun, 5 Jan 2003 22:53:23 +0000 (22:53 +0000)]
Move x11fwd and portfwd prototypes from ssh.c into ssh.h so they can be seen
by (and checked against) the definitions.

[originally from svn r2474]

21 years agoSC in "finding an actual bug" shocker! Set the port number before passing
Ben Harris [Sun, 5 Jan 2003 22:52:11 +0000 (22:52 +0000)]
SC in "finding an actual bug" shocker!  Set the port number before passing
it to name_lookup().

[originally from svn r2473]

21 years agosshsha.c and sshmd5.c compile fine on PowerPC now.
Ben Harris [Sun, 5 Jan 2003 15:31:45 +0000 (15:31 +0000)]
sshsha.c and sshmd5.c compile fine on PowerPC now.

[originally from svn r2471]

21 years agoMake SHA_Core_Init() (only used in this file) static.
Ben Harris [Sun, 5 Jan 2003 15:31:09 +0000 (15:31 +0000)]
Make SHA_Core_Init() (only used in this file) static.

[originally from svn r2470]

21 years agoMake MD5_Core_Init and MD5_Block (both only referenced in this file) static.
Ben Harris [Sun, 5 Jan 2003 15:29:22 +0000 (15:29 +0000)]
Make MD5_Core_Init and MD5_Block (both only referenced in this file) static.

[originally from svn r2469]

21 years ago"possible unintended assignment"? I think not.
Ben Harris [Sun, 5 Jan 2003 14:23:30 +0000 (14:23 +0000)]
"possible unintended assignment"?  I think not.

[originally from svn r2468]

21 years agochar * vs unsigned char * (by explicit cast).
Ben Harris [Sun, 5 Jan 2003 14:20:49 +0000 (14:20 +0000)]
char * vs unsigned char * (by explicit cast).

[originally from svn r2467]

21 years agoCommas at the end of enumerator lists aren't allowed.
Ben Harris [Sun, 5 Jan 2003 14:18:00 +0000 (14:18 +0000)]
Commas at the end of enumerator lists aren't allowed.

[originally from svn r2466]

21 years agoEliminate more unsigned char * vs char * errors using explicit casts.
Ben Harris [Sun, 5 Jan 2003 14:14:51 +0000 (14:14 +0000)]
Eliminate more unsigned char * vs char * errors using explicit casts.

[originally from svn r2465]

21 years agoFix more unsigned char * vs char * warnings, usually by making implicit
Ben Harris [Sun, 5 Jan 2003 14:11:14 +0000 (14:11 +0000)]
Fix more unsigned char * vs char * warnings, usually by making implicit
casts explicit.

[originally from svn r2464]

21 years agoReplace implict char-*-to-unsigned-char-* casts with explicit ones.
Ben Harris [Sun, 5 Jan 2003 14:00:16 +0000 (14:00 +0000)]
Replace implict char-*-to-unsigned-char-* casts with explicit ones.

[originally from svn r2463]

21 years agoSC (Apple's 68K C compiler) seems to treat tentative definitions of complete
Ben Harris [Sun, 5 Jan 2003 13:57:09 +0000 (13:57 +0000)]
SC (Apple's 68K C compiler) seems to treat tentative definitions of complete
arrya as full definitions, and hence gets upset when it finds a full definition
later.  This is a bug (see K&R2 A10.2), but an easy one to work around by
making the tentative definitions incomplete, so I've done that.

[originally from svn r2462]

21 years agoDeal with "possible unintended assignment" warnings.
Ben Harris [Sun, 5 Jan 2003 13:46:13 +0000 (13:46 +0000)]
Deal with "possible unintended assignment" warnings.

[originally from svn r2461]