]> asedeno.scripts.mit.edu Git - PuTTY.git/log
PuTTY.git
17 years agoCtrl-Break now sends a Break signal (previously it was equivalent to Ctrl-C).
Jacob Nevins [Sun, 18 Feb 2007 14:02:39 +0000 (14:02 +0000)]
Ctrl-Break now sends a Break signal (previously it was equivalent to Ctrl-C).

[originally from svn r7295]
[this svn revision also touched putty-wishlist]

17 years agoUse preprocessor trickery to make the signal translation mechanism a little
Ben Harris [Sat, 17 Feb 2007 22:33:11 +0000 (22:33 +0000)]
Use preprocessor trickery to make the signal translation mechanism a little
less hideous.  The output of the preprocessor should be basically unchanged.

[originally from svn r7294]

17 years agossh2_set_window checks whether the channel is being closed, so there's no
Ben Harris [Sat, 17 Feb 2007 22:15:57 +0000 (22:15 +0000)]
ssh2_set_window checks whether the channel is being closed, so there's no
need to check that before calling it.

[originally from svn r7293]

17 years agoUnbreak "Duplicate session" on Windows, in a similar way to r7291.
Jacob Nevins [Sat, 17 Feb 2007 17:44:24 +0000 (17:44 +0000)]
Unbreak "Duplicate session" on Windows, in a similar way to r7291.

[originally from svn r7292]
[r7291 == 062b5ab3e412435b9c452b371b51beeaa026608e]

17 years agor7265 broke the legacy `putty @sessionname' construction, which I
Simon Tatham [Fri, 16 Feb 2007 18:44:07 +0000 (18:44 +0000)]
r7265 broke the legacy `putty @sessionname' construction, which I
wouldn't care about except for the fact that it's still used to
implement the Saved Sessions menu item in PuTTY and Pageant.

[originally from svn r7291]
[r7265 == 5d76e00dac9220e8798e4d0f17a4069a58ae1667]

17 years agoLICENCE in the installer should have CP/M line endings.
Jacob Nevins [Thu, 15 Feb 2007 23:27:29 +0000 (23:27 +0000)]
LICENCE in the installer should have CP/M line endings.

[originally from svn r7290]

17 years agoIt turns out that HH_INITIALIZE and HH_UNINITIALIZE are optional, and are for
Jacob Nevins [Tue, 13 Feb 2007 22:57:19 +0000 (22:57 +0000)]
It turns out that HH_INITIALIZE and HH_UNINITIALIZE are optional, and are for
putting HTML Help into "single-threaded" mode. Furthermore, this requires
extra work from the application (message pumping via HH_PRETRANSLATEMESSAGE).

Thus, remove them and run Help in a secondary thread. This means that keyboard
input into the Index and Search tabs now works.

[originally from svn r7285]

17 years agoNote that htmlhelp.h from HTML Help Workshop works perfectly well with Cygwin.
Jacob Nevins [Sun, 11 Feb 2007 20:27:05 +0000 (20:27 +0000)]
Note that htmlhelp.h from HTML Help Workshop works perfectly well with Cygwin.

[originally from svn r7273]

17 years agoTypo.
Jacob Nevins [Sun, 11 Feb 2007 18:09:03 +0000 (18:09 +0000)]
Typo.

[originally from svn r7271]

17 years agoSince we're now able to cope with Default Settings describing a
Simon Tatham [Sat, 10 Feb 2007 17:12:06 +0000 (17:12 +0000)]
Since we're now able to cope with Default Settings describing a
launchable session without getting confused by it, we can relax the
restriction on storing a host name in DS, which has attracted a
steady stream of complaints over the past six or seven years.

[originally from svn r7266]

17 years agoAvoid launching a session from the Default Settings, even if they do
Simon Tatham [Sat, 10 Feb 2007 17:02:41 +0000 (17:02 +0000)]
Avoid launching a session from the Default Settings, even if they do
represent a launchable session, unless the user can be construed to
have really meant it. This means:
 - starting up PuTTY when the Default Settings are launchable still
   brings up the config box, and you have to hit Open to actually
   launch that session
 - double-clicking on Default Settings from the config box will load
   them but not launch them.
On the other hand:
 - explicitly loading the Default Settings on the command line using
   `-load' _does_ still launch them.

[originally from svn r7265]

17 years agoI've changed my mind about the PuTTY build script. It now delivers
Simon Tatham [Thu, 8 Feb 2007 18:53:11 +0000 (18:53 +0000)]
I've changed my mind about the PuTTY build script. It now delivers
the release directory into a _subdirectory_ of the main build.out,
and delivers the link maps and sign.sh alongside it. That simplifies
both the nightly snapshot cron job (which now doesn't have to
carefully move the maps out of the release directory or go looking
in strange places for sign.sh) and my release procedure (for much
the same reasons).

[originally from svn r7258]

17 years agoThe big payoff from bob (from my POV at least): the PuTTY release
Simon Tatham [Thu, 8 Feb 2007 09:24:08 +0000 (09:24 +0000)]
The big payoff from bob (from my POV at least): the PuTTY release
procedure is now a huge amount less painful.

[originally from svn r7249]

17 years ago`installer.ico' doesn't fit into 8.3, so gets truncated to INSTALLE.ICO in
Jacob Nevins [Tue, 6 Feb 2007 22:39:15 +0000 (22:39 +0000)]
`installer.ico' doesn't fit into 8.3, so gets truncated to INSTALLE.ICO in
the Windows source Zips. Rename to `puttyins.ico'.

[originally from svn r7241]

17 years agoWhen emitting SSH_MSG_IGNORE to protect against known-IV attacks on CBC,
Ben Harris [Tue, 6 Feb 2007 13:57:27 +0000 (13:57 +0000)]
When emitting SSH_MSG_IGNORE to protect against known-IV attacks on CBC,
remember to put an empty string in it rather than sending a completely
empty packet.  This should help with those servers (notably RomSShell)
that actually check the contents of SSH_MSG_IGNORE.

[originally from svn r7236]

17 years agoAhem; other half of r7232...
Simon Tatham [Mon, 5 Feb 2007 20:14:17 +0000 (20:14 +0000)]
Ahem; other half of r7232...

[originally from svn r7233]
[r7232 == 6ee6a4d37926062f5b610de4cef2a6ce4fe63345]

17 years agoWhen calling TIOCSCTTY, it helps to pass it an fd that's still open,
Simon Tatham [Mon, 5 Feb 2007 20:04:33 +0000 (20:04 +0000)]
When calling TIOCSCTTY, it helps to pass it an fd that's still open,
instead of one we closed two lines earlier. I apparently broke this
in r7107.

[originally from svn r7232]
[r7107 == 32b25c13dae27bb4f485ab2d2c4737572fa28251]

17 years agoAvoid passing modified SVN revision numbers (of the form 1234M) to
Simon Tatham [Mon, 5 Feb 2007 18:07:11 +0000 (18:07 +0000)]
Avoid passing modified SVN revision numbers (of the form 1234M) to
parts of the versioning code which might not like them.

As a result of this checkin, bob builds from modified SVN working
copies will still announce themselves as revision nnnnM in the
textual version strings, but their binary version in the Windows
VERSIONINFO will now be 0.0.0.0.

[originally from svn r7231]

17 years agoFiddle further with .htaccess: add some $s on the ends of the
Simon Tatham [Mon, 5 Feb 2007 15:01:28 +0000 (15:01 +0000)]
Fiddle further with .htaccess: add some $s on the ends of the
regexps to stop them matching the wrong files.

[originally from svn r7229]

17 years agoHTTP redirects for the variably-named signatures as well as their
Simon Tatham [Mon, 5 Feb 2007 14:23:34 +0000 (14:23 +0000)]
HTTP redirects for the variably-named signatures as well as their
base files. (The signatures aren't actually _generated_ by bob, of
course, but the redirects are harmless in their absence.)

[originally from svn r7228]

17 years agoScript to generate signatures on the various PuTTY build outputs.
Simon Tatham [Mon, 5 Feb 2007 13:53:48 +0000 (13:53 +0000)]
Script to generate signatures on the various PuTTY build outputs.
Saves me having to remember all the fiddly gpg arguments every time.
Should be usable for both releases (with manual passphrase input)
and snapshots (run automatically).

[originally from svn r7227]

17 years agoFixes for snapshot building using bob. All of releases, snapshots
Simon Tatham [Mon, 5 Feb 2007 12:49:24 +0000 (12:49 +0000)]
Fixes for snapshot building using bob. All of releases, snapshots
and custom svn builds should now have appropriately named Unix
source archives and installer binaries, plus .htaccess files
providing redirects to them from totally standard filenames. I
_think_ this now makes it feasible to switch the nightly builds to
using bob.

[originally from svn r7226]

17 years agoBe slightly more forgiving about the nature of SVN_REV; bob will be
Simon Tatham [Mon, 5 Feb 2007 08:02:53 +0000 (08:02 +0000)]
Be slightly more forgiving about the nature of SVN_REV; bob will be
reliable at defining it, and it's useful to be able to pass `1234M'-
type revisions in for testing purposes.

[originally from svn r7221]

17 years agoFix errors in $(Makeargs) which only occur when building development
Simon Tatham [Mon, 5 Feb 2007 08:02:01 +0000 (08:02 +0000)]
Fix errors in $(Makeargs) which only occur when building development
snapshots.

[originally from svn r7220]

17 years agoPuTTY builds should save the map files.
Simon Tatham [Sun, 4 Feb 2007 12:37:20 +0000 (12:37 +0000)]
PuTTY builds should save the map files.

[originally from svn r7212]

17 years agoVersion management updates for the new bob build script. There's now
Simon Tatham [Sun, 4 Feb 2007 12:30:39 +0000 (12:30 +0000)]
Version management updates for the new bob build script. There's now
a fourth class of PuTTY version tags in addition to release,
snapshot and unidentified: we now have `Custom build r1234',
indicating a build made from that SVN revision in a context other
than that of a dated snapshot. The build script generates these when
it doesn't know what else to do; `unidentified builds' will now only
occur when you run nmake from the command line.

Also, the build script now generates sensible version data in the
installer to match this. So I _think_ we should now be set to use
bob to generate installer builds of the nightly snapshots, although
of course I'll have to wait until tomorrow to test one.

[originally from svn r7211]

17 years agoDocument \\.\COM10 faff on Windows.
Jacob Nevins [Sun, 4 Feb 2007 12:12:52 +0000 (12:12 +0000)]
Document \\.\COM10 faff on Windows.
References:
<http://msdn2.microsoft.com/en-us/library/aa363858.aspx> (CreateFile() docs)
  describes the use of \\.\
<http://msdn2.microsoft.com/en-us/library/aa365247.aspx> ("Naming a File")
  lists the reserved filenames (COM1-COM9, LPT1-LPT9, CON, PRN, AUX, NUL)

[originally from svn r7208]

17 years agoBuild script for PuTTY using bob.
Simon Tatham [Sun, 4 Feb 2007 11:17:45 +0000 (11:17 +0000)]
Build script for PuTTY using bob.

[originally from svn r7205]

17 years agoSwap order of `Columns' and `Rows' in the config dialog, to make it
Jacob Nevins [Thu, 1 Feb 2007 23:24:30 +0000 (23:24 +0000)]
Swap order of `Columns' and `Rows' in the config dialog, to make it
consistent with sizetip.c (and more nebulous conventions).

[originally from svn r7196]

17 years agoColin Watson has fixed the disgusting icons on GTK1. His patch
Simon Tatham [Wed, 31 Jan 2007 12:30:48 +0000 (12:30 +0000)]
Colin Watson has fixed the disgusting icons on GTK1. His patch
appears to merely fix the background colour (arranging for it to
have transparency rather than being on some kind of default grey
background), but it turns out to also fix the strange blurry
behaviour I see in the GNOME Taskbar, for no very obvious reason.

[originally from svn r7186]

17 years agoIn the cases where Setup asks to restart the computer, explain exactly why this
Jacob Nevins [Mon, 29 Jan 2007 20:10:51 +0000 (20:10 +0000)]
In the cases where Setup asks to restart the computer, explain exactly why this
is deemed necessary.

[originally from svn r7179]

17 years agoSwitch round the order of CFLAGS and XFLAGS, so that the latter
Simon Tatham [Fri, 26 Jan 2007 19:43:15 +0000 (19:43 +0000)]
Switch round the order of CFLAGS and XFLAGS, so that the latter
comes last on the compiler command line. This makes it easier to
override the normal compile options (since conflicting command-line
options usually follow a last-wins policy) in order to compile (for
example) the Unix version -g -O0.

[originally from svn r7170]

17 years agoIf I'd tested under Minefield before releasing, r7168 would have
Simon Tatham [Fri, 26 Jan 2007 14:11:56 +0000 (14:11 +0000)]
If I'd tested under Minefield before releasing, r7168 would have
been committed before the release. Therefore, stick it on the
checklist for next time.

[originally from svn r7169]
[r7168 == b3a5cdc5fbab8884755690286211fa6b3425d9d3]

17 years agoKai Jourdan spotted a rather embarrassing double-free, and Minefield
Simon Tatham [Fri, 26 Jan 2007 14:06:08 +0000 (14:06 +0000)]
Kai Jourdan spotted a rather embarrassing double-free, and Minefield
confirms that it's a real problem.

[originally from svn r7168]

17 years agoWe may as well update the website icon to match the other new ones.
Jacob Nevins [Thu, 25 Jan 2007 00:14:01 +0000 (00:14 +0000)]
We may as well update the website icon to match the other new ones.

[originally from svn r7153]
[this svn revision also touched putty-website]

17 years agoPost-release corrections to the checklist.
Simon Tatham [Wed, 24 Jan 2007 21:43:11 +0000 (21:43 +0000)]
Post-release corrections to the checklist.

[originally from svn r7151]

17 years agoVersion number bumps, and associated changes, for the 0.59 release. 0.59
Simon Tatham [Wed, 24 Jan 2007 20:16:33 +0000 (20:16 +0000)]
Version number bumps, and associated changes, for the 0.59 release.

[originally from svn r7146]

17 years agoThe direct link between the terminal and the back end via
Simon Tatham [Wed, 24 Jan 2007 13:53:28 +0000 (13:53 +0000)]
The direct link between the terminal and the back end via
term_provide_resize_fn() was not being broken when the back end was
destroyed on session termination, causing resizing an inactive PuTTY
to be a segfault hazard.

[originally from svn r7143]

17 years agofaq-xpwontrun wants tweaking before the next release.
Jacob Nevins [Wed, 24 Jan 2007 11:20:14 +0000 (11:20 +0000)]
faq-xpwontrun wants tweaking before the next release.

[originally from svn r7142]

17 years agoMention XXX-REVIEW-BEFORE-RELEASE in the same place as
Jacob Nevins [Tue, 23 Jan 2007 14:12:42 +0000 (14:12 +0000)]
Mention XXX-REVIEW-BEFORE-RELEASE in the same place as
XXX-REMOVE-BEFORE-RELEASE.

[originally from svn r7141]

17 years agoMention the potential networked-CHM problem in the post-installer
Simon Tatham [Tue, 23 Jan 2007 11:38:11 +0000 (11:38 +0000)]
Mention the potential networked-CHM problem in the post-installer
README.

[originally from svn r7140]

17 years agoChecklist updates for the upcoming release, mostly to do with the
Simon Tatham [Tue, 23 Jan 2007 11:15:56 +0000 (11:15 +0000)]
Checklist updates for the upcoming release, mostly to do with the
retirement of the Alpha build.

[originally from svn r7139]

17 years agoAdd an icon for the PuTTY installer. Design concept (and noticing
Simon Tatham [Mon, 22 Jan 2007 18:02:06 +0000 (18:02 +0000)]
Add an icon for the PuTTY installer. Design concept (and noticing
that Inno Setup had an option to specify an icon) by Jacob; detailed
artwork and translation into Python by me.

[originally from svn r7136]

17 years agoImprove error reporting.
Simon Tatham [Mon, 22 Jan 2007 14:04:33 +0000 (14:04 +0000)]
Improve error reporting.

[originally from svn r7135]

17 years agoFix several bugs that stopped %proxyport from doing anything useful.
Jacob Nevins [Sun, 21 Jan 2007 23:34:51 +0000 (23:34 +0000)]
Fix several bugs that stopped %proxyport from doing anything useful.

[originally from svn r7133]

17 years agoFix Plink, the serial backend, and local-proxy support on Win98SE (at least),
Jacob Nevins [Sun, 21 Jan 2007 23:34:35 +0000 (23:34 +0000)]
Fix Plink, the serial backend, and local-proxy support on Win98SE (at least),
which have been broken since r6797.
(At least some versions of Win9x are gratuitously picky about the arguments to
CreateThread(), requiring lpThreadId not to be NULL.)

[originally from svn r7132]
[r6797 == 291533d3f9abb6f33ebe2a73f34420fc9f8e9433]

17 years agoFix compiles on GCC 3.3, which doesn't know about assert(0);
Ben Harris [Sat, 20 Jan 2007 20:05:46 +0000 (20:05 +0000)]
Fix compiles on GCC 3.3, which doesn't know about assert(0);

[originally from svn r7130]

17 years agoMention more versions of Windows. (Not Vista, yet.)
Jacob Nevins [Sat, 20 Jan 2007 16:14:13 +0000 (16:14 +0000)]
Mention more versions of Windows. (Not Vista, yet.)

[originally from svn r7127]

17 years agoDon't use C99 mid-block declarations and don't do arithmetic on void *.
Ben Harris [Sat, 20 Jan 2007 14:13:57 +0000 (14:13 +0000)]
Don't use C99 mid-block declarations and don't do arithmetic on void *.
This helps with compilations on ancient Sun compilers.

[originally from svn r7126]

17 years agoMove README.txt into windows subdir.
Jacob Nevins [Fri, 19 Jan 2007 14:33:56 +0000 (14:33 +0000)]
Move README.txt into windows subdir.
It's specific to the Windows installer, so it seems unnecessarily confusing to
have it in the top level of the source distribution alongside README.

[originally from svn r7125]

17 years agoFlag user cancellation of authentication as a clean exit, so that it
Simon Tatham [Wed, 17 Jan 2007 18:38:45 +0000 (18:38 +0000)]
Flag user cancellation of authentication as a clean exit, so that it
will close the window even in `close window only on clean exit'
mode. Also, while I'm here, arrange a suitable exit code for
"exit-signal".

[originally from svn r7121]

17 years agoUpdate WINVER to 0x500 to avoid build failures from Jacob's
Simon Tatham [Tue, 16 Jan 2007 21:32:02 +0000 (21:32 +0000)]
Update WINVER to 0x500 to avoid build failures from Jacob's
FlashWindow changes. Also fiddle with the <multimon.h> include,
which was subtly broken in turn by that.

[originally from svn r7120]

17 years agoAt least, I have the technology to fix `beepind-win2k'.
Jacob Nevins [Tue, 16 Jan 2007 20:54:58 +0000 (20:54 +0000)]
At least, I have the technology to fix `beepind-win2k'.
Tested on Win98, Win2K, and WinXP.

[originally from svn r7119]
[this svn revision also touched putty-wishlist]

17 years agoAdd more ifdefs to make uxser.c compile on OS X.
Simon Tatham [Tue, 16 Jan 2007 19:26:24 +0000 (19:26 +0000)]
Add more ifdefs to make uxser.c compile on OS X.

[originally from svn r7118]

17 years agoFold up the `SSH' branch of the treeview by default; it's getting
Simon Tatham [Tue, 16 Jan 2007 18:48:47 +0000 (18:48 +0000)]
Fold up the `SSH' branch of the treeview by default; it's getting
quite big and tends to hide the existence of the `Serial' config
panel.

This is implemented by folding up every branch of depth 2 or more,
which with any luck might turn out to be general enough to carry
over unchanged if other branches start expanding. Then again, we may
have to fiddle with it again when that time comes; who knows?

[originally from svn r7117]

17 years agoI've just realised that the data-logging options only work in PuTTY proper.
Jacob Nevins [Sun, 14 Jan 2007 21:50:44 +0000 (21:50 +0000)]
I've just realised that the data-logging options only work in PuTTY proper.
Document this.

[originally from svn r7108]

17 years agoRemove the loops that close all open fds before running a
Simon Tatham [Sun, 14 Jan 2007 13:44:07 +0000 (13:44 +0000)]
Remove the loops that close all open fds before running a
subprocess. They were intended to make sure the child process didn't
inherit anything embarrassing or inconvenient from us, such as the
master end of its own pty, but now we instead do this by making sure
to set all our own fds to not-FD_CLOEXEC on creation. This should
fix Debian bug #357520.

(This doesn't seem to work _quite_ right in uxproxy.c's invocation
of a local proxy command: both ends of a GTK internal pipe end up in
the child process's fd space. This appears to be another GTK 1 bug,
inasmuch as it goes away when I build with Colin's preliminary GTK 2
patch; for the moment I think leaving that pipe lying around is
probably less harmful than hampering the proxy process's ability to
use extra fds by prior arrangement with PuTTY's parent process.)

[originally from svn r7107]

17 years agoExperimental fix for `psftp-hang'. (Experimental only in that I haven't thought
Jacob Nevins [Fri, 12 Jan 2007 23:35:46 +0000 (23:35 +0000)]
Experimental fix for `psftp-hang'. (Experimental only in that I haven't thought
about it very hard; it's a plausible fix for the observed cause of the extreme
CPU usage, being that we were asking to be notified of Windows messages and
then not dealing with them, plausibly leading to a loop. Works for me,
anyway.)

[originally from svn r7098]

17 years agoRemove redundant sentence.
Jacob Nevins [Fri, 12 Jan 2007 20:00:32 +0000 (20:00 +0000)]
Remove redundant sentence.

[originally from svn r7097]

17 years agoMiscellaneous updates.
Jacob Nevins [Wed, 10 Jan 2007 00:54:08 +0000 (00:54 +0000)]
Miscellaneous updates.

[originally from svn r7090]

17 years agoAccording to Frank Dijcks, this cast makes OpenWatcom happier.
Jacob Nevins [Wed, 10 Jan 2007 00:46:45 +0000 (00:46 +0000)]
According to Frank Dijcks, this cast makes OpenWatcom happier.

[originally from svn r7089]

17 years agoVarious SSH-related things were appearing in the PuTTYtel configuration dialog,
Jacob Nevins [Wed, 10 Jan 2007 00:16:53 +0000 (00:16 +0000)]
Various SSH-related things were appearing in the PuTTYtel configuration dialog,
probably since the addition of the serial backend. Use a more robust check for
SSH support.

[originally from svn r7088]

17 years agoMinGW needs an extra symbol _WIN32_IE defined to a particular value before
Jacob Nevins [Tue, 9 Jan 2007 23:47:15 +0000 (23:47 +0000)]
MinGW needs an extra symbol _WIN32_IE defined to a particular value before
it'll let you see an identifier (SHGFP_TYPE_CURRENT) referenced since r7082.
(Actually, you need a pretty recent w32api before it's there at all.)

Morally, this should be defined for all toolchains, not just MinGW/Cygwin, but  I'll leave that to people who have those toolchains.
<http://msdn2.microsoft.com/en-us/library/aa383745.aspx>

Also add some other comments on our use of this API (since it's a horrible one
that I suspect will come back and haunt us...)

[originally from svn r7087]
[r7082 == dbbd6eb5ecdad5eb0b010e9ad4997fac53356189]
[this svn revision also touched putty-wishlist]

17 years agoGet rid of all the MSVC warnings.
Simon Tatham [Tue, 9 Jan 2007 18:24:07 +0000 (18:24 +0000)]
Get rid of all the MSVC warnings.

[originally from svn r7086]

17 years agoFix `puttygen-unix-perms': f_open(), PuTTY's wrapper on fopen, now
Simon Tatham [Tue, 9 Jan 2007 18:14:30 +0000 (18:14 +0000)]
Fix `puttygen-unix-perms': f_open(), PuTTY's wrapper on fopen, now
takes a third argument which is TRUE if the file is being opened for
writing and wants to be created in such a way that it's readable
only to the owner. This is used when saving private keys.

While I'm here, I also use this option when writing session logs, on
the general principle that they probably contain _something_
sensitive.

The new argument is only supported on Unix, for the moment. (I think
writing owner-accessible-only files is the default on Windows.)

[originally from svn r7084]

17 years agoFix `win-randseed-location': use SHGetFolderPath() to find the
Simon Tatham [Tue, 9 Jan 2007 18:05:17 +0000 (18:05 +0000)]
Fix `win-randseed-location': use SHGetFolderPath() to find the
Application Data directory in preference to the old-fashioned
attempt to find the user's home directory, and use the _local-
machine_ Application Data directory in preference even to that.

SHGetFolderPath() is called via GetProcAddress, so this degrades
gracefully on old Windowses. (Tested myself on Win95.)

As part of this change, we now search for a location for the seed
file separately for reading and writing, so that installing the new
PuTTY should cause a seamless migration as the old seed file is read
from the old location and then a new one written to the new location.

`putty -cleanup' attempts to delete the seed file from _all_
affected locations.

Naturally, a user-specified seed file path in the Registry still
takes priority over all other means of finding the location.

[originally from svn r7082]

17 years agoThe remaining issue in `win-askappend-multi' appears to have been
Simon Tatham [Mon, 8 Jan 2007 19:38:39 +0000 (19:38 +0000)]
The remaining issue in `win-askappend-multi' appears to have been
caused by the MessageBox() internal message loop eating WinSock
FD_READ notifications, which then don't reappear afterwards because
you have to explicitly prod a socket in order to get a repeat
notification on it.

Hence, here's a piece of infrastructure which seems to sort it out:
a new winnet.c function called socket_reselect_all(), whose function
is to go through all currently active sockets and re-run
WSAAsyncSelect() on them, causing repeat notifications for anything
we might have missed. I call this after every call to MessageBox(),
and that seems to solve the problem.

(The problem was actually masked in very recent revisions, probably
by the reinstatement of pending_netevent in r7071. However, I don't
believe that was a complete fix. This should be.)

[originally from svn r7077]
[r7071 == 57a763b0ec55b84d6a515e6d860759898d648869]

17 years agoHave one call to from_backend() per call to do_telnet_read(),
Simon Tatham [Mon, 8 Jan 2007 18:54:49 +0000 (18:54 +0000)]
Have one call to from_backend() per call to do_telnet_read(),
instead of the previous rate of one per character. In `Flush log
file frequently' mode, the latter was causing excessive slowdown due
to fflush()ing once per byte.

[originally from svn r7076]

17 years agoFix ssh2-cisco-pw-pad by reverting r5122. However, I've kept the
Simon Tatham [Sun, 7 Jan 2007 14:30:24 +0000 (14:30 +0000)]
Fix ssh2-cisco-pw-pad by reverting r5122. However, I've kept the
ability to easily re-enable the r5122 behaviour, in case we need to
conditionally switch between the two at a later date.

[originally from svn r7073]
[r5122 == 8a20515844a0cc83272c4f72c5eb01615f70a196]
[this svn revision also touched putty-wishlist]

17 years agoGreater leniency when importing private key files: accept both CRLF
Simon Tatham [Sun, 7 Jan 2007 14:20:28 +0000 (14:20 +0000)]
Greater leniency when importing private key files: accept both CRLF
and LF, and don't object if the final line of the key lacks a
newline. Also, while I'm here, switch to using fgetline() throughout
so as not to have to do nasty buffer-size ad-hockery.

[originally from svn r7072]

17 years agoReinstate RDB's pending_netevent mechanism, which was removed in
Simon Tatham [Sun, 7 Jan 2007 12:40:21 +0000 (12:40 +0000)]
Reinstate RDB's pending_netevent mechanism, which was removed in
r4906 in the process of adding the new timing code. It seems to have
been what was previously preventing spew-lockup, and still seems to
prevent it now I've put it back in.

[originally from svn r7071]
[r4906 == 7ecf13564a8d716000ce78146d1aaf4422432a4f]
[this svn revision also touched putty-wishlist]

17 years agoTweak the icon script, and the generated icons, to more closely
Simon Tatham [Sun, 7 Jan 2007 10:17:12 +0000 (10:17 +0000)]
Tweak the icon script, and the generated icons, to more closely
match the original icons. (Apparently I managed to introduce errors
while transcribing the originals for detailed analysis.)

While I'm at it, add the obviously useful `make install' target in
icons/Makefile, and fix the svn:ignore property on the icons
directory.

[originally from svn r7068]

17 years agoI think this change to Recipe was accidentally omitted from r7064.
Jacob Nevins [Sat, 6 Jan 2007 20:01:30 +0000 (20:01 +0000)]
I think this change to Recipe was accidentally omitted from r7064.

[originally from svn r7065]
[r7064 == 334ef0824cdafc77f184137c3b6fca0f9c0342cf]

17 years agoNo, I tell a lie: GTK 1 _does_ support icons, at least partially. Ooh.
Simon Tatham [Sat, 6 Jan 2007 18:27:00 +0000 (18:27 +0000)]
No, I tell a lie: GTK 1 _does_ support icons, at least partially. Ooh.

[originally from svn r7064]

17 years agoShiny new script which constructs the various icons for the PuTTY
Simon Tatham [Sat, 6 Jan 2007 18:15:35 +0000 (18:15 +0000)]
Shiny new script which constructs the various icons for the PuTTY
suite. In a dramatic break with tradition, I'm actually checking in
the resulting icon files as well as the script that generates them,
because the script requires Python and ImageMagick and I don't think
it's reasonable to require that much extra infrastructure on
everyone checking out from Subversion.

The new icons should be _almost_ indistinguishable from the old
ones, at least at the 32x32 resolution. The immediately visible
change is that all the icons now come in 16x16, 32x32 and 48x48
formats, in both 16 colours and monochrome, instead of an ad-hoc
mixture of whichever ones I could be bothered to draw.

The same code can also be adapted to generate icons for the GTK port
(although icons for the running programs don't seem to be supported
by GTK 1 - another reason to upgrade to GTK 2!).

[originally from svn r7063]

17 years agoFrancois L'Archeveque spotted that the variable `winsock2_module'
Simon Tatham [Fri, 5 Jan 2007 18:43:58 +0000 (18:43 +0000)]
Francois L'Archeveque spotted that the variable `winsock2_module'
only exists when compiling for IPv6, so we shouldn't try assigning
to it the rest of the time.

[originally from svn r7059]

17 years agoIt's a new year.
Jacob Nevins [Mon, 1 Jan 2007 21:19:14 +0000 (21:19 +0000)]
It's a new year.

[originally from svn r7048]
[this svn revision also touched putty-website,puzzles]

17 years agoPatch inspired by one from Daniel Silverstone in Debian bug #229232:
Jacob Nevins [Sun, 31 Dec 2006 15:33:33 +0000 (15:33 +0000)]
Patch inspired by one from Daniel Silverstone in Debian bug #229232:

We now have an option where a remote window title query returns a well-formed
response containing the empty string. This should keep stop any server-side
application that was expecting a response from hanging, while not permitting
the response to be influenced by an attacker.

We also retain the ability to stay schtum. The existing checkbox has thus
grown into a set of radio buttons.

I've changed the default to the "empty string" response, even in the backward-
compatibility mode of loading old settings, which is a change in behaviour;
any users who want the old behaviour back will have to explicitly select it. I
think this is probably the Right Thing. (The only drawback I can think of is
that an attacker could still potentially use the relevant fixed strings for
mischief, but we already have other, similar reports.)

[originally from svn r7043]

17 years agoPatch from Colin Watson intended to give a clean Unix compile with GCC 4.
Jacob Nevins [Sat, 30 Dec 2006 23:00:14 +0000 (23:00 +0000)]
Patch from Colin Watson intended to give a clean Unix compile with GCC 4.
(Since we choose to compile with -Werror, this is particularly important.)

I haven't yet checked that the resulting source actually compiles cleanly with
GCC 4, hence not marking `gcc4-warnings' as fixed just yet.

[originally from svn r7041]

17 years agoUse va_copy() where available. This should fix a segfault in vsnprintf()
Jacob Nevins [Fri, 29 Dec 2006 16:38:52 +0000 (16:38 +0000)]
Use va_copy() where available. This should fix a segfault in vsnprintf()
on AMD 64 Linux.
(This has been sitting in my checkout for ages and hasn't obviously caused
any trouble -- I think I was waiting to get round to trying it with VC6, which
I haven't yet. There are some notes in comments on further tweaks that could
be made.)

[originally from svn r7035]

17 years agoColin Watson points out that there was no need for me to write the
Simon Tatham [Fri, 29 Dec 2006 14:35:34 +0000 (14:35 +0000)]
Colin Watson points out that there was no need for me to write the
custom Panels container widget for the PuTTY config box, since the
perfectly standard GtkNotebook does the same job. Hence, let's
remove Panels completely in favour of doing it the proper way.

[originally from svn r7034]

17 years agoAdd a NO_HTMLHELP option, and enable it by default in the Cygwin Makefile,
Jacob Nevins [Thu, 28 Dec 2006 20:56:01 +0000 (20:56 +0000)]
Add a NO_HTMLHELP option, and enable it by default in the Cygwin Makefile,
since even the latest version of w32api (3.6) shows no sign of HTMLHelp
support.

(This touches mkfiles.pl because that's where the details of what Cygwin
doesn't support are kept currently. This may be deliberate, so I haven't
changed it.)

[originally from svn r7032]

17 years agoI'm not sure why I added htmlhelp.lib to the PuTTY link lines in
Simon Tatham [Thu, 28 Dec 2006 15:47:53 +0000 (15:47 +0000)]
I'm not sure why I added htmlhelp.lib to the PuTTY link lines in
r7000. I was probably half asleep. Actually, it's completely
unnecessary to bind to it at link time, because we load it at run
time in order to continue working as before on Win95. So I'm
removing it again.

[originally from svn r7030]
[r7000 == 1dac1bc911bd76446f19c48fbca9c868c33f07ca]

17 years agoNearly forgot: add the .CHM to the PuTTY installer. This involves
Simon Tatham [Thu, 28 Dec 2006 10:39:56 +0000 (10:39 +0000)]
Nearly forgot: add the .CHM to the PuTTY installer. This involves
making the manual shortcut in the Start menu point to one or other
of the two help files depending on the version of Windows;
fortunately Inno Setup has no difficulty doing that.

[originally from svn r7028]

17 years ago`make mostlyclean', to remove everything directly Halibut-generated
Simon Tatham [Thu, 28 Dec 2006 10:38:46 +0000 (10:38 +0000)]
`make mostlyclean', to remove everything directly Halibut-generated
but not the CHM. It'll come in useful during the release process.

[originally from svn r7027]

17 years agoAdd some CHM-related stuff to the release checklist. Don't want to
Simon Tatham [Sun, 24 Dec 2006 16:25:30 +0000 (16:25 +0000)]
Add some CHM-related stuff to the release checklist. Don't want to
forget about it when the time comes.

[originally from svn r7012]

17 years agoAfter discussion with Jeroen Massar, here's a patch (mostly his)
Simon Tatham [Sat, 23 Dec 2006 09:04:27 +0000 (09:04 +0000)]
After discussion with Jeroen Massar, here's a patch (mostly his)
which we think fixes the vista-ipv6 problem.

[originally from svn r7007]

17 years agoMinor style tweaks for the CHM.
Simon Tatham [Tue, 19 Dec 2006 10:28:44 +0000 (10:28 +0000)]
Minor style tweaks for the CHM.

[originally from svn r7002]

17 years agoSort out line-endings on new file.
Jacob Nevins [Sun, 17 Dec 2006 17:46:12 +0000 (17:46 +0000)]
Sort out line-endings on new file.

[originally from svn r7001]

17 years agoInitial support for HTML Help. All the ad-hoc help-file finding code
Simon Tatham [Sun, 17 Dec 2006 11:16:07 +0000 (11:16 +0000)]
Initial support for HTML Help. All the ad-hoc help-file finding code
and various calls to WinHelp() have been centralised into a new file
winhelp.c, which in turn has been modified to detect a .CHM file as
well as .HLP and select between them as appropriate. It explicitly
tries to load HHCTRL.OCX and use GetProcAddress, meaning that it
_should_ still work correctly on pre-HTML-Help platforms, falling
gracefully back to WinHelp, but although I tested this by
temporarily renaming my own HHCTRL.OCX I haven't yet been able to
test it on a real HTML-Help-free platform.

Also in this checkin: a new .but file and docs makefile changes to
make it convenient to build the sources for a .CHM. As yet, owing to
limitations of Halibut's CHM support, I'm not able to write a .CHM
directly, more's the pity.

[originally from svn r7000]

17 years agoSet FD_CLOEXEC in a little convenience function that does the right thing
Ben Harris [Sat, 9 Dec 2006 15:44:31 +0000 (15:44 +0000)]
Set FD_CLOEXEC in a little convenience function that does the right thing
with F_GETFD and F_SETFD.

[originally from svn r6978]

17 years agoCorrect an embarrassingly wrong comment.
Simon Tatham [Tue, 28 Nov 2006 21:51:54 +0000 (21:51 +0000)]
Correct an embarrassingly wrong comment.

[originally from svn r6926]

17 years agoI've just discovered that using the saved sessions menu from Unix
Simon Tatham [Thu, 23 Nov 2006 14:32:11 +0000 (14:32 +0000)]
I've just discovered that using the saved sessions menu from Unix
PuTTY causes the child process to inherit a lot of socket fds from
its parent, which is a pain if one of them then ends up holding open
a listening socket which the parent was using for port forwarding
after the parent itself is dead.

Therefore, this checkin sprinkles FD_CLOEXEC throughout the Unix
platform directory wherever there looks like being a long-lived fd.

[originally from svn r6917]

17 years agoReinstate as much of the Windows font-linking behaviour as I can
Simon Tatham [Sat, 18 Nov 2006 15:10:48 +0000 (15:10 +0000)]
Reinstate as much of the Windows font-linking behaviour as I can
easily manage, by adopting a hybrid approach to Unicode text
display. The old approach of simply calling ExtTextOutW provided
font linking without us having to lift a finger, but didn't do the
right thing when it came to bidirectional or Arabic-shaped text.
Arabeyes' replacement exact_textout() supported the latter, but
turned out to break the former (with no warning from the Windows API
documentation, so it's not their fault).

So now I've got a second wrapper layer called general_textout(),
which splits the input string into substrings based on bidi
character class. Any character liable to cause bidi or shaping
behaviour if fed straight to ExtTextOutW is instead fed through
Arabeyes' exact_textout(), but the rest is fed straight to
ExtTextOutW as it used to be.

The effect appears to be that font linking is restored for all
characters _except_ Arabic and other bidi scripts, which means in
particular that we are no longer in a state of regression over 0.57.
(0.57 would have done font linking on Arabic as well, but would also
have misbidied it, so we've merely exchanged one failure mode for
another slightly less harmful one in that situation.)

[originally from svn r6910]

17 years agoChris Boucher spotted that after "-nc" was added (r6823), cfg->ssh_nc_host
Jacob Nevins [Wed, 15 Nov 2006 23:42:22 +0000 (23:42 +0000)]
Chris Boucher spotted that after "-nc" was added (r6823), cfg->ssh_nc_host
was not always initialised, which could lead to spurious attempts to open
a bogus channel (typically refused: "FATAL ERROR: Server refused to open
a direct-tcpip channel"). Fixed.

[originally from svn r6907]
[r6823 == 631b4948073922c2618441fb374c7e6fc22bd1d8]

17 years ago(Config).remote_cmd2[512] was added in r1208, but it wasn't used then and isn't
Jacob Nevins [Wed, 15 Nov 2006 23:12:20 +0000 (23:12 +0000)]
(Config).remote_cmd2[512] was added in r1208, but it wasn't used then and isn't
now, so presumably never has been. Remove.

[originally from svn r6906]
[r1208 == ff9a038cdda2703b96f4a79396efe5b7b8e0aec2]

17 years agopublickeyfile now an RFC
Jacob Nevins [Wed, 15 Nov 2006 12:56:48 +0000 (12:56 +0000)]
publickeyfile now an RFC

[originally from svn r6905]
[this svn revision also touched putty-website]

17 years agoLink to faq-cleanup from faq-settings.
Jacob Nevins [Wed, 15 Nov 2006 11:48:07 +0000 (11:48 +0000)]
Link to faq-cleanup from faq-settings.

[originally from svn r6904]

17 years agoThere's been an increase in people posting non-SSH PuTTY-related questions
Jacob Nevins [Wed, 8 Nov 2006 21:15:30 +0000 (21:15 +0000)]
There's been an increase in people posting non-SSH PuTTY-related questions
to comp.security.ssh, posting queries that are clearly about PuTTY to
newsgroups without actually mentioning PuTTY, and so on. They may have been
directed there by this document :( Add a futile attempt to instil a sense of
etiquette.

[originally from svn r6895]

17 years agoAdministrivia: most SSH-2 specs are no longer drafts.
Jacob Nevins [Wed, 8 Nov 2006 00:55:13 +0000 (00:55 +0000)]
Administrivia: most SSH-2 specs are no longer drafts.

[originally from svn r6890]