Ben Harris [Mon, 17 Mar 2003 21:40:37 +0000 (21:40 +0000)]
Partial implementation of the platform-independent dialogue-box interface
for the Mac OS. This isn't anywhere near complete, and is wrong in a few
important regards, but I think it's heading in the right direction.
Simon Tatham [Mon, 17 Mar 2003 16:57:23 +0000 (16:57 +0000)]
Error messages update. It's now abundantly clear that WSAECONNABORTED
is not the same thing as ECONNABORTED, so I've removed the `we're a
bit confused about this, send us details' text. And someone has just
been confused by `connection timed out', so I've added that too.
Simon Tatham [Sun, 16 Mar 2003 12:37:48 +0000 (12:37 +0000)]
Further work on the GTK config box; mostly implemented keyboard
shortcuts now (only treeviews and list boxes to go, which currently
do very weird things and I need to overhaul them completely).
Simon Tatham [Sat, 15 Mar 2003 17:51:05 +0000 (17:51 +0000)]
Implement RSA blinding, to defeat Brumley and Boneh's RSA timing
attacks. In the PuTTY suite I'm pretty sure they're only applicable
to a forwarded Pageant, and if your remote sysadmin is abusing your
Pageant then you're shafted _anyway_; but it can't hurt to take
precautions now, just in case things change in future.
Simon Tatham [Sat, 15 Mar 2003 15:56:51 +0000 (15:56 +0000)]
When a piece of text overflows its column in a tabbed list box, I
think on balance I rather like the natural behaviour of the way I've
done it, except that non-zero separation between the columns would
be even nicer. Accordingly, here is some.
Simon Tatham [Sat, 15 Mar 2003 15:50:42 +0000 (15:50 +0000)]
Event handling in the GTK dialog engine is now basically present and
correct. All the callbacks are getting called, all the dialog
actions are working (the port forwarding, colour and charclass
configurers are all completely functional), file, font and colour
selectors happen, and it's all looking pretty cool.
Simon Tatham [Sat, 15 Mar 2003 09:42:15 +0000 (09:42 +0000)]
Missed a couple of the Unix-specific settings out of settings.c. One
of these days I'll have to separate the platform-specific settings
out into winsett and uxsett modules, but for now it's not too urgent.
Simon Tatham [Fri, 14 Mar 2003 21:20:32 +0000 (21:20 +0000)]
While I'm adding explanatory comments by the coroutine macros, it
occurs to me that would also be a good place to put a copy of the
instructions for disabling Edit and Continue debugging. Nobody
_actually_ reads the README, after all...
Simon Tatham [Fri, 14 Mar 2003 18:35:01 +0000 (18:35 +0000)]
Continuing work on the GTK config box. Created uxcfg.c for the
Unix-specific config items; moved a stray Windows-specific config
item (scrollbar-in-fullscreen) out into wincfg.c to stop it
appearing on Unix; continued updates to gtkdlg.c. I now believe the
GTK config box looks basically correct (modulo minor cosmetic issues
and keyboard accelerators). Next step, add the event handling so
it's actually functional.
Simon Tatham [Thu, 13 Mar 2003 19:52:28 +0000 (19:52 +0000)]
First stab at a GTK layout engine. It's missing all sorts of stuff
(list boxes are particularly conspicuously absent), it has no event
handling at all, and it isn't in any way integrated into pterm - you
have to build it specially using the test stubs in gtkdlg.c. But
what there is so far seems to work plausibly well, so it's a start.
Rather than browbeat the existing GTK container/layout widgets into
doing what I wanted, I decided to implement two subclasses of
GtkContainer myself, which implement precisely the layout model
assumed by the config box specification; this has the rather cool
consequence that the box can be resized and will maintain the same
layout at all times that it would have had if initially created at
that size.
Simon Tatham [Tue, 11 Mar 2003 09:30:31 +0000 (09:30 +0000)]
Never pass a `char' to a ctype function. I had relied on gcc -Wall
letting me know about instances of this, but it turns out that my
ctype.h explicitly casts input values to `int' to evade the
`subscript has type char' warning, so it had been carefully not
letting me know! Found them all by compiling with a doctored
ctype.h, and hopefully fixed them all too.
Simon Tatham [Sat, 8 Mar 2003 11:46:42 +0000 (11:46 +0000)]
Add the ability to allocate extra per-dialog-instance private data
in the portable dialog interface. This has allowed me to remove
`ssd->savedsession' in config.c, which was (I believe) the only
out-of-place piece of per-instance data in the dialog template
stuff. Now we should actually be able to run more than one config
box in the same process at the same time (for platforms that'll find
that useful).
Simon Tatham [Fri, 7 Mar 2003 18:18:38 +0000 (18:18 +0000)]
Richard B's patch for resize behaviour. The scrollback now contains
a marker which defines everything before it as `permanent'
scrollback and everything after it as `temporary'; only temporary
scrollback lines are returned to the main screen when the window
height is increased. Screen clears mark the lines pushed into the
scrollback as permanent; so lines explicitly cleared off the screen
by ESC[2J are never returned to it by mistake. This patch also fixes
the incorrect state the primary screen is left in when the window is
resized while the alternate screen is active.
Ben Harris [Thu, 6 Mar 2003 23:44:47 +0000 (23:44 +0000)]
Slightly better than null verify_ssh_host_key(). It's broken in more ways
than I can comfortably enumerate (see the comments in the code), but it's
better than always assuming everything's OK.
Simon Tatham [Thu, 6 Mar 2003 19:18:25 +0000 (19:18 +0000)]
Got a bit of a better handle on the whole GDI `logical units' mess,
and sorted out the static-control text wrapping rather better. Now
it works under both large fonts and small fonts on Win2K, so I have
high hopes that it's actually correct this time.
Simon Tatham [Thu, 6 Mar 2003 13:24:02 +0000 (13:24 +0000)]
Reorganisation of misc.c: Minefield has moved out to winmisc.c, and
so has the Windows dputs() - which has also acquired a Unix
counterpart in uxmisc.c. -DDEBUG should now work on Unix.
Simon Tatham [Thu, 6 Mar 2003 12:51:12 +0000 (12:51 +0000)]
Richard B's patch to push erased text into the scrollback on ESC[2J
clears, and also to temporarily push the primary screen contents
into the scrollback while the alternate screen is active and bring
it back afterwards.
Simon Tatham [Wed, 5 Mar 2003 22:07:40 +0000 (22:07 +0000)]
The long-awaited config box revamp! I've taken the whole config box
to pieces, and put it back together in a new table-driven form.
config.c sets up a data structure describing most of the config box;
wincfg.c adds in the Windows-specific options (so that config.c can
also form the basis for Mac and Unix config boxes). Then winctrls.c
contains a shiny new layout engine which consumes that data
structure, and windlg.c passes all WM_COMMAND and similar messages
to a driver alongside that layout engine. In the process I've sorted
out nicer-looking panel titles and finally fixed the list-boxes-are-
never-the-right-size bug (turned out to be Windows's fault, of
course). I _believe_ it should do everything the old config box did,
including context help. Now everyone has to test it thoroughly...
Simon Tatham [Mon, 3 Mar 2003 16:35:45 +0000 (16:35 +0000)]
I've been meaning to get round to this for _ages_: in front of my
coroutine macros, I now include a comment linking to my web article
that explains what they do.
Ben Harris [Sat, 1 Mar 2003 15:12:03 +0000 (15:12 +0000)]
Improve scheduling on the Mac:
1: Only update the screen when there's nothing else to do. This means that
it's a lot harder for a fast typist to outrun PuTTY.
2: Only sleep for at most 100ms at a time. This is a kludge to work around
the WakeUpProcess caused by incoming data can happen before the
WaitNextEvent it's meant to interrupt, leading to PuTTY sleeping forever
because it doesn't know there's network data pending.
Ben Harris [Thu, 27 Feb 2003 23:21:23 +0000 (23:21 +0000)]
Add 'plst' 0 resources to help Mac OS X do magic things.
These aren't actually compiled yet because they must only be present in
the Carbon build, and I don't currently compile the resources separately for
each platform.
Ben Harris [Sun, 23 Feb 2003 13:00:38 +0000 (13:00 +0000)]
Don't open the event log whenever an event is logged; instead handle the
"Show Event Log" menu entry sensibly. Similarly, make it possible to close
(hide) the event log.
Ben Harris [Sun, 23 Feb 2003 11:58:59 +0000 (11:58 +0000)]
Add handling for suspend and resume events, and set the flags in our 'SIZE'
resource that say we can handle them. This seems to avoid a crash when PuTTY's
switched away from, and is necessary for Carbon anyway.
Ben Harris [Sun, 23 Feb 2003 00:13:17 +0000 (00:13 +0000)]
Work around an SC bug that causes it to try to use the same register for
two purposes in s_wrpkt_prepare(). This makes SSH1 work on 68K Macs, at
least until I deactivate the terminal window...
Ben Harris [Thu, 20 Feb 2003 22:55:09 +0000 (22:55 +0000)]
Add a mechanism for collecting entropy, and displaying how much we've got,
based on the Windows version. We don't _do_ anything with the entropy yet,
though.
Ben Harris [Thu, 20 Feb 2003 22:31:52 +0000 (22:31 +0000)]
Be careful not to try to get information from windows we don't own, or that
don't exist at all. Also a small PuTTYgen change that I can't be bothered
to filter out of this commit.
Jacob Nevins [Sat, 15 Feb 2003 18:47:22 +0000 (18:47 +0000)]
faq-support:
Modified text to reflect the fact that the wishlist now shows bugs fixed
recently (FSVO "recently"). Hopefully I haven't made it too confusing.
Ben Harris [Sat, 15 Feb 2003 16:22:15 +0000 (16:22 +0000)]
Rather than increasing the size of my switch statements yet further, have
a bunch of function pointers associated with each window to do things like
updates and click handling. This is all looking disturbingly object-oriented.
.
While I'm here, separate out the about box into its own file, shared by PuTTY
and PuTTYgen.
Ben Harris [Fri, 7 Feb 2003 01:38:12 +0000 (01:38 +0000)]
Crude Event Log implementation for the Mac. I'm fairly convinced now that
using the List Manager was entirely the wrong decision on my part, so I'll
probably rewrite this to use TextEdit at some point, but it's better than
stderr even so.
Simon Tatham [Tue, 4 Feb 2003 13:02:51 +0000 (13:02 +0000)]
Add another bug workaround, this one for old OpenSSH (<2.3) servers
which have a strange idea of what data should be signed in a PK auth
request. This actually got in my way while doing serious things at
work! :-)
Simon Tatham [Tue, 4 Feb 2003 13:00:54 +0000 (13:00 +0000)]
Further fallout from the introduction of the Filename type. (Memo to
self: if you change the type of a variable and everything compiles
without type-checking errors, that doesn't mean it's all fixed,
because variadic functions aren't type-checked! Oops.)
Ben Harris [Tue, 4 Feb 2003 02:08:03 +0000 (02:08 +0000)]
I can only quote the comment in <Scrap.h> which prompted this commit:
/*
Newsflash! After 15 years of arduous toil, it's finally possible
for specially trained typists wielding advanced text editing
technology to define symbolic names for commonly used scrap
flavor type constants! Apple triumphs again!
*/
Ben Harris [Tue, 4 Feb 2003 02:03:53 +0000 (02:03 +0000)]
Fix various breakages my Carbonisation caused in the Classic build, notably
that outside Carbon, CGrafPtr and GrafPtr are different types, even though
they're mostly interchangeable, so we need to interpose a cast between
GetWindowPort and SetPort.