Simon Tatham [Tue, 28 Aug 2001 08:43:33 +0000 (08:43 +0000)]
D'oh! Putting keyboard-interactive authentication _before_ publickey
causes password login to occur on a server that supports password-
through-k-i. Of course when we use the new preference list mechanism
for selecting the order of authentications this will all become much
more sane, but for the moment I've put publickey back up to the top
and things seem to be happier.
Simon Tatham [Tue, 28 Aug 2001 08:36:27 +0000 (08:36 +0000)]
Fix externally added SSH1 keys in Pageant. I have no idea how this
code _ever_ worked before! But it's been like this for four months
and nobody has noticed, including me. That's quite spooky.
Simon Tatham [Mon, 27 Aug 2001 17:40:03 +0000 (17:40 +0000)]
PuTTYgen: add an extra button to save a public key into a file
(as well as showing it for cut and paste). For SSH1, this feature is
largely cosmetic and added for orthogonality; it comes into its own
in SSH2, where it saves the Official One True Public Key Format as
specified in the draft spec, and more particularly as used by
ssh.com's product for authentication. Now that ssh-3.0.1 supports
RSA user keys, this is suddenly actually useful.
Simon Tatham [Mon, 27 Aug 2001 15:59:37 +0000 (15:59 +0000)]
Port forwarding update: local-host-only listening sockets are now
done properly (by binding to INADDR_LOOPBACK) instead of hackishly
(by binding to INADDR_ANY, looking at the peer address when a
connection is accepted, and slamming the connection shut at that
point).
Simon Tatham [Mon, 27 Aug 2001 15:13:14 +0000 (15:13 +0000)]
Port forwarding bug fix: we were unable to handle receiving
CHANNEL_OPEN_FAILURE messages, which occur when the remote side is
unable to open a forwarded network connection we have requested. (It
seems they _don't_ show up if you get something mundane like
Connection Refused - the channel is cheerfully opened and
immediately slammed shut - but they do if you try to connect to a
host that doesn't even exist. Try forwarding a port to
frogwibbler:4800 and see what you get.)
Simon Tatham [Mon, 27 Aug 2001 15:02:52 +0000 (15:02 +0000)]
Finally tighten up the server-side wildcard security hole, the
_right_ way. (SSWs are disabled by default and can be re-enabled
using `-unsafe', meaning that pscp will _never_ do anything
unexpected to your local file system unless you explicitly give
consent. The sftp-based variant will work fine because the
corresponding mechanism is _not_ unsafe.)
Simon Tatham [Mon, 27 Aug 2001 10:24:55 +0000 (10:24 +0000)]
Minor modification: in remote->local non-recursive mode matching a
wildcard, we don't abandon ship completely if the wildcard matches a
directory; we just warn and carry on with the rest.
Simon Tatham [Sun, 26 Aug 2001 18:32:28 +0000 (18:32 +0000)]
PSCP now uses the modern SFTP protocol if it can, and falls back to
scp1 if it can't. Currently not very tested - I checked it in as
soon as it completed a successful recursive copy in both directions.
Also, one known bug: you can't specify a remote wildcard, because by
the nature of SFTP we'll need to implement the wildcard engine on
the client side. I do intend to do this (and use the same wildcard
engine in PSFTP as well) but I haven't got round to it yet.
Simon Tatham [Sun, 26 Aug 2001 15:45:55 +0000 (15:45 +0000)]
Arrgh; yet again I make my security checking too draconian to
actually get things done. I'm sure this is the second time I've
checked in this mistake :-/ Still, this time I've got right to the
bottom of the cause, and commented it clearly. Phew.
Simon Tatham [Sun, 26 Aug 2001 15:31:29 +0000 (15:31 +0000)]
Further tightening up in PSCP. Fixed a couple more holes whereby a
malicious SCP server could have written to areas other than the ones
the user requested; cleared up buffer overruns everywhere. Hopefully
we now do not use arbitrary buffer limits _anywhere_.
Simon Tatham [Sun, 26 Aug 2001 14:53:51 +0000 (14:53 +0000)]
Preparatory work for allowing PSCP to work over SFTP as well as old-
style scp1. I've built a layer of abstraction covering all the gory
details of the old scp network protocol.
Simon Tatham [Sat, 25 Aug 2001 19:33:33 +0000 (19:33 +0000)]
Jacob's patch for a drag-list to select SSH ciphers. Heavily hacked
by me to make the drag list behaviour slightly more intuitive.
WARNING: DO NOT LOOK AT pl_itemfrompt() IF YOU ARE SQUEAMISH.
Simon Tatham [Sat, 25 Aug 2001 17:09:23 +0000 (17:09 +0000)]
Extensive changes that _should_ fix the socket buffering problems,
by ceasing to listen on input channels if the corresponding output
channel isn't accepting data. Has had basic check-I-didn't-actually-
break-anything-too-badly testing, but hasn't been genuinely tested
in stress conditions (because concocting stress conditions is non-
trivial).
Simon Tatham [Wed, 22 Aug 2001 19:47:05 +0000 (19:47 +0000)]
Fix to allow more than one challenge/response pair during
keyboard-interactive authentication. UNTESTED except that I checked
it compiles. Will ask for testing from the user who complained.
Simon Tatham [Sun, 12 Aug 2001 19:25:21 +0000 (19:25 +0000)]
First phase of Unicode polishing: replace the edit box with a combo
box. Also default to ISO8859-1 so that CSI works in the default
mode; this is ridiculously Western-centric but I can't honestly
think of a better option.
Simon Tatham [Thu, 9 Aug 2001 21:22:38 +0000 (21:22 +0000)]
Stop yelling about Access Denied if the server refuses even to
attempt keyboard-interactive authentication. We can yell about it if
we make a creditable attempt and are rejected, but if the server
just refuses to even consider it then the user won't really want to
know (and if they do there's the Event Log).
Simon Tatham [Wed, 8 Aug 2001 20:44:35 +0000 (20:44 +0000)]
SSH port forwarding! How cool is that?
Only currently works on SSH1; SSH2 should be doable but it's late
and I have other things to do tonight. The Cool Guy award for this
one goes to Nicolas Barry, for doing most of the work and actually
understanding the code he was adding to.
Simon Tatham [Sat, 4 Aug 2001 15:45:25 +0000 (15:45 +0000)]
Glenn Maynard's patch completely disabled PuTTY{,tel} on any system
that didn't support OSVERSIONINFOEX. For example, such wildly out of
date things as NT4. Now fixed.
Simon Tatham [Tue, 31 Jul 2001 14:23:21 +0000 (14:23 +0000)]
Yet another possible segfault path in the backends fixed. I don't
_believe_ I'm still finding these. I have no idea what I was
thinking when I wrote this stuff.
Simon Tatham [Fri, 15 Jun 2001 19:31:10 +0000 (19:31 +0000)]
Add some extra documentation: filled in the Getting Started chapter,
added an introduction to public key authentication, and made a
couple of changes in intro.but. Transatlantic flights have some uses
after all.
Simon Tatham [Mon, 21 May 2001 13:33:12 +0000 (13:33 +0000)]
Oops - fixing the line-resizing segfault introduced a new
line-resizing segfault! Remind me to test under Minefield next time.
Should now be fine, as I've just done so.
Simon Tatham [Sat, 19 May 2001 15:23:12 +0000 (15:23 +0000)]
Add some spare SetForegroundWindow and SetActiveWindow calls to try
to improve window behaviour. Also make the About box a subdialog of
the config box instead of a separate child of the root.
Simon Tatham [Thu, 17 May 2001 08:53:13 +0000 (08:53 +0000)]
Fix the line-resizing bug in scroll(). (Thanks to RDB for pointing
it out. A line was removed from the scrollback, cleared, and placed
at the bottom of the screen. Fine, except that the clearing process
assumed the line was the right length already, and thanks to lazy
resizing this wasn't necessarily the case. Segfaults and memory
corruption ensued.)
Simon Tatham [Sun, 13 May 2001 14:11:49 +0000 (14:11 +0000)]
The host-key-unknown prompt now offers the same three options as the
host-key-changed prompt: update-cache-and-connect, connect-without-
updating-cache, and abandon-connection. (Previously the middle one
was missing.)
Simon Tatham [Sun, 13 May 2001 11:58:36 +0000 (11:58 +0000)]
Jacob's patch to make pressing Return on a selected saved session
load it and go, and simultaneously allow Alt-L on a selected saved
session not to change the focus.
Simon Tatham [Sun, 13 May 2001 10:45:56 +0000 (10:45 +0000)]
Added a new large icon for the PuTTY config box. Doesn't show up in
the actual window at all, but appears in the Alt-Tab task switcher
box in place of the tedious Windows Default icon.
Simon Tatham [Thu, 10 May 2001 08:34:20 +0000 (08:34 +0000)]
RDB's Unicode patch. Fonts are now used in Unicode mode where
possible and we have a single unified means of trying to display any
Unicode code point. Instead of the various ad-hoc translation modes
we had before, we now have a single `codepage' option which allows
us to treat the incoming (and outgoing) text as any given character
set, and locally we map that to Unicode and back.
Simon Tatham [Wed, 9 May 2001 15:12:26 +0000 (15:12 +0000)]
From RDB: a patch to allow special keys (^C, ^Z, Delete, Return) to
send Telnet special sequences (Interrupt Process, Suspend, Erase
Char, End Of Line) instead of their ASCII equivalents. In particular
Return -> Telnet End Of Line is _always_ enabled irrespective of the
configuration, while the others are optional. Also in this patch, an
entertainingly ghastly use of `switch' to allow literal ^M^J to do
the same thing as magic-^M (the Return key) when in Raw protocol.
Simon Tatham [Wed, 9 May 2001 13:30:06 +0000 (13:30 +0000)]
From RDB: according to VT manuals, application cursor keys should
never be enabled when app keypad is disabled. Also CTRL+arrows flips
the application-ness to make it easy to generate the other sequences
if required.
Simon Tatham [Wed, 9 May 2001 13:03:16 +0000 (13:03 +0000)]
RDB's alternative way to interpret the window size in Change
Settings: it describes the size of the _unmaximised_ window.
Maximisedness is a separate property which Change Settings doesn't
affect. So if you change the font while the window is maximised, the
terminal size adjusts accordingly. The downside is that you can't
read the width and height of a maximised window out of Change
Settings. Suggestions that restore this property are welcome.