]> asedeno.scripts.mit.edu Git - linux.git/commit
io_uring: only test SQPOLL cpu after we've verified it
authorJens Axboe <axboe@kernel.dk>
Sat, 13 Apr 2019 15:28:55 +0000 (09:28 -0600)
committerJens Axboe <axboe@kernel.dk>
Sun, 14 Apr 2019 01:08:22 +0000 (19:08 -0600)
commit917257daa0fea7a007102691c0e27d9216a96768
treeb9eb940786c1bc428f79025919777848b2fd6e54
parent06058632464845abb1af91521122fd04dd3daaec
io_uring: only test SQPOLL cpu after we've verified it

We currently call cpu_possible() even if we don't use the CPU. Move the
test under the SQ_AFF branch, which is the only place where we'll use
the value. Do the cpu_possible() test AFTER we've limited it to a max
of NR_CPUS. This avoids triggering the following warning:

WARNING: CPU: 1 PID: 7600 at include/linux/cpumask.h:121 cpu_max_bits_warn

if CONFIG_DEBUG_PER_CPU_MAPS is enabled.

While in there, also move the SQ thread idle period assignment inside
SETUP_SQPOLL, as we don't use it otherwise either.

Reported-by: syzbot+cd714a07c6de2bc34293@syzkaller.appspotmail.com
Fixes: 6c271ce2f1d5 ("io_uring: add submission polling")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c