]> asedeno.scripts.mit.edu Git - linux.git/commit
ubifs: Fix uninitialized variable in search_dh_cookie()
authorGeert Uytterhoeven <geert@linux-m68k.org>
Sun, 17 Sep 2017 08:32:20 +0000 (10:32 +0200)
committerRichard Weinberger <richard@nod.at>
Wed, 17 Jan 2018 18:28:53 +0000 (19:28 +0100)
commitc877154d307f4a91e0b5b85b75535713dab945ae
tree88a8b224272d08b87ad8223d9c2eab97411140c0
parenta8750ddca918032d6349adbf9a4b6555e7db20da
ubifs: Fix uninitialized variable in search_dh_cookie()

fs/ubifs/tnc.c: In function ‘search_dh_cookie’:
fs/ubifs/tnc.c:1893: warning: ‘err’ is used uninitialized in this function

Indeed, err is always used uninitialized.

According to an original review comment from Hyunchul, acknowledged by
Richard, err should be initialized to -ENOENT to avoid the first call to
tnc_next().  But we can achieve the same by reordering the code.

Fixes: 781f675e2d7e ("ubifs: Fix unlink code wrt. double hash lookups")
Reported-by: Hyunchul Lee <hyc.lee@gmail.com>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Richard Weinberger <richard@nod.at>
fs/ubifs/tnc.c