]> asedeno.scripts.mit.edu Git - linux.git/commit
net: dccp: initialize (addr,port) listening hashtable
authorPeter Oskolkov <posk@google.com>
Sun, 16 Dec 2018 23:42:48 +0000 (15:42 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 18 Dec 2018 07:11:48 +0000 (23:11 -0800)
commiteedbbb0d98b2a89250a8bb83d9c71b77881e5247
tree69b9bf067315f9c8e3561d42d2a0b21abed330e4
parent6a95147c513190b8932c5ea695cb653272cf2c14
net: dccp: initialize (addr,port) listening hashtable

Commit d9fbc7f6431f "net: tcp: prefer listeners bound to an address"
removes port-only listener lookups. This caused segfaults in DCCP
lookups because DCCP did not initialize the (addr,port) hashtable.

This patch adds said initialization.

The only non-trivial issue here is the size of the new hashtable.
It seemed reasonable to make it match the size of the port-only
hashtable (= INET_LHTABLE_SIZE) that was used previously. Other
parameters to inet_hashinfo2_init() match those used in TCP.

V2 changes: marked inet_hashinfo2_init as an exported symbol
so that DCCP compiles when configured as a module.

Tested: syzcaller issues fixed; the second patch in the patchset
        tests that DCCP lookups work correctly.

Fixes: d9fbc7f6431f "net: tcp: prefer listeners bound to an address"
Reported-by: syzcaller <syzkaller@googlegroups.com>
Signed-off-by: Peter Oskolkov <posk@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dccp/proto.c
net/ipv4/inet_hashtables.c