From 038d06984f5c50a101c1cf47bc6419064042716d Mon Sep 17 00:00:00 2001 From: Chao Yu Date: Thu, 25 Jul 2019 22:39:11 +0800 Subject: [PATCH] f2fs: disallow direct IO in atomic write Atomic write needs page cache to cache data of transaction, direct IO should never be allowed in atomic write, detect and deny it when open atomic write file. Signed-off-by: Gao Xiang Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim --- fs/f2fs/file.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 1e27b4bc852d..a5080bea6b0b 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -1825,6 +1825,9 @@ static int f2fs_ioc_start_atomic_write(struct file *filp) if (!S_ISREG(inode->i_mode)) return -EINVAL; + if (filp->f_flags & O_DIRECT) + return -EINVAL; + ret = mnt_want_write_file(filp); if (ret) return ret; -- 2.45.2